-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big-endian fixes: PDB creation by ilasm #59422
Conversation
* Fix byte order of debug directory fields * Fix byte order of PDB stream data (PdbHeap::SetData)
Tagging subscribers to this area: @JulieLeeMSFT Issue Details
|
Yet more endian issues in This bug currently causes source-build to fail on s390x with the latest .NET 6 code, because a PDB file for an assembly created via Therefore, it would be great if this fix could still make it into .NET 6, ideally RC2. |
CC @dotnet/jit-contrib PTAL. Community request to backport to .NET 6 RC2. |
/azp run runtime-coreclr ilasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The failures are #58481 |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1260093631 |
/backport to release/6.0-rc2 |
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1262715856 |
Fix byte order of debug directory fields
Fix byte order of PDB stream data (PdbHeap::SetData)