Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-rc2] Big-endian fixes: PDB creation by ilasm #59484

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 22, 2021

Backport of #59422 to release/6.0-rc2

/cc @BruceForstall @uweigand

Customer Impact

Fixes s390x platform source-build using .NET 6 tools. No impact to supported .NET 6 platforms.

Testing

Regular PR testing + ilasm/ildasm round-trip pri-1 test run.

Risk

Low

* Fix byte order of debug directory fields

* Fix byte order of PDB stream data (PdbHeap::SetData)
@ghost
Copy link

ghost commented Sep 22, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #59422 to release/6.0-rc2

/cc @BruceForstall @uweigand

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-ILTools-coreclr

Milestone: -

@dotnet dotnet deleted a comment from azure-pipelines bot Sep 22, 2021
@JulieLeeMSFT
Copy link
Member

cc @dotnet/jit-contrib PTAL PR for backporting to .NET 6 rc2.

@BruceForstall
Copy link
Member

Interesting: Libraries Test Run checked coreclr Linux_musl arm64 Release failed with a GC assert:

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-59484-merge-b97d5a2515314a99b1/System.Text.Json.Tests/1/console.04bc49ae.log?sv=2019-07-07&se=2021-10-12T17%3A46%3A30Z&sr=c&sp=rl&sig=%2FUKyGZNpi1W5xCIUx1tAlPKpX0Qui2tufwJ%2Bfe91Hqw%3D

Assert failure(PID 95 [0x0000005f], Thread: 141 [0x008d]): ptrdiff_t(GetNumSeries()) > 0
    File: /__w/1/s/src/coreclr/vm/../gc/gcdesc.h Line: 178
    Image: /root/helix/work/correlation/dotnet

This failed before with #39672, but @mangod9 recently closed the issue as it hadn't been seen in a while.

Will rerun the test, but is certainly not due to this PR.

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Sep 23, 2021
@jeffschwMSFT jeffschwMSFT added this to the 6.0.0 milestone Sep 23, 2021
@Anipik Anipik merged commit 09c45da into release/6.0-rc2 Sep 23, 2021
@Anipik Anipik deleted the backport/pr-59422-to-release/6.0-rc2 branch September 23, 2021 16:45
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ILTools-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants