-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Fix loading a non wasm page and then returning to a wasm page. #60688
Conversation
Tagging subscribers to this area: @thaystg Issue DetailsIt was creating a new store, but it was not creating a new SdbHelper nor cleaning the cache, now when I set the store on SdbHelper I clear the cache. I think we can open a PR to servicing, or maybe to 6.0? I don't think it's too risky.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing the comments 👍
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIt was creating a new store, but it was not creating a new SdbHelper nor cleaning the cache, now when I set the store on SdbHelper I clear the cache. I think we can open a PR to servicing, or maybe to 6.0? I don't think it's too risky.
|
@lewing will we backport it? |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1373379841 |
It was creating a new store, but it was not creating a new SdbHelper nor cleaning the cache, now when I set the store on SdbHelper I clear the cache.
Also don't throw an exception when have an error while trying to call the debugger functions (as it was done before moving to use debugger-agent).
I think we can open a PR to servicing, or maybe to 6.0? I don't think it's too risky.
Fixes #60613