Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Fix loading a non wasm page and then returning to a wasm page. #60688

Merged
merged 5 commits into from
Oct 22, 2021

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Oct 20, 2021

It was creating a new store, but it was not creating a new SdbHelper nor cleaning the cache, now when I set the store on SdbHelper I clear the cache.
Also don't throw an exception when have an error while trying to call the debugger functions (as it was done before moving to use debugger-agent).

I think we can open a PR to servicing, or maybe to 6.0? I don't think it's too risky.
Fixes #60613

@ghost
Copy link

ghost commented Oct 20, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

It was creating a new store, but it was not creating a new SdbHelper nor cleaning the cache, now when I set the store on SdbHelper I clear the cache.
Also don't throw an exception when have an error while trying to call the debugger functions (as it was done before moving to use debugger-agent).

I think we can open a PR to servicing, or maybe to 6.0? I don't think it's too risky.

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the comments 👍

@radical radical added the arch-wasm WebAssembly architecture label Oct 20, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

It was creating a new store, but it was not creating a new SdbHelper nor cleaning the cache, now when I set the store on SdbHelper I clear the cache.
Also don't throw an exception when have an error while trying to call the debugger functions (as it was done before moving to use debugger-agent).

I think we can open a PR to servicing, or maybe to 6.0? I don't think it's too risky.
Fixes #60613

Author: thaystg
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@thaystg
Copy link
Member Author

thaystg commented Oct 22, 2021

@lewing will we backport it?

@thaystg thaystg merged commit 3cc122b into dotnet:main Oct 22, 2021
@lewing
Copy link
Member

lewing commented Oct 22, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1373379841

@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[blazor] [wasm] Unable to debug after redirect to oidc
4 participants