Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [wasm][debugger] Fix loading a non wasm page and then returning to a wasm page. #60777

Merged
merged 5 commits into from
Oct 22, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 22, 2021

Backport of #60688 to release/6.0

/cc @lewing @thaystg

Customer Impact

Fixes #60613 in 6.0. Wasm debugging can fail after page redirection under some circumstances. This fix resolves a stale cache and an issue with error handling in failed debugger commands.

Testing

Manual and Automated

Risk

Low

@ghost
Copy link

ghost commented Oct 22, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #60688 to release/6.0

/cc @lewing @thaystg

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@lewing lewing added the arch-wasm WebAssembly architecture label Oct 22, 2021
@ghost
Copy link

ghost commented Oct 22, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #60688 to release/6.0

/cc @lewing @thaystg

Customer Impact

Wasm debugging can fail after page redirection under some circumstances. This fix resolve a stale cache and an issue with error handling in failed debugger commands.

Testing

Manual and Automated

Risk

Low

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: 6.0.1

@lewing lewing added the Servicing-consider Issue for next servicing release review label Oct 22, 2021
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 22, 2021
@lewing
Copy link
Member

lewing commented Oct 22, 2021

@mmitche this is the pr we discussed, merge when ready.

@lewing lewing modified the milestones: 6.0.1, 6.0.0 Oct 22, 2021
@mmitche mmitche merged commit bf20df1 into release/6.0 Oct 22, 2021
@lewing lewing deleted the backport/pr-60688-to-release/6.0 branch October 22, 2021 20:29
@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants