Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in jit #61129

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Remove dead code in jit #61129

merged 1 commit into from
Nov 3, 2021

Conversation

echesakov
Copy link
Contributor

Noticed that the code is dead while working on an issue

@dotnet/jit-contrib PTAL

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 2, 2021
@ghost
Copy link

ghost commented Nov 2, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Noticed that the code is dead while working on an issue

@dotnet/jit-contrib PTAL

Author: echesakovMSFT
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I presume no asmdiffs?

@echesakov
Copy link
Contributor Author

LGTM. I presume no asmdiffs?

I will double check this before merging

@echesakov
Copy link
Contributor Author

Confirmed no diffs with spmi on all four platforms.

@echesakov echesakov merged commit 49807bc into dotnet:main Nov 3, 2021
@echesakov echesakov deleted the Remove-Dead-Code branch November 3, 2021 03:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants