Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [wasm][debugger] Avoiding assert on mono runtime #62816

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Dec 14, 2021

Backport of #62601 to release/6.0

/cc @thaystg

Customer Impact

As VS tries to evaluate a lot of things while hover the mouse on variables while debugging, could be causing assert on runtime in the case of trying to evaluate in a static class that is in a loaded assembly but not added any breakpoint on it.

Testing

Unit tests and manual tests on Blazor.

Risk

Low Risk, only checking the debugId of the assembly and getting the correct one before send to debugger-agent.

@ghost
Copy link

ghost commented Dec 14, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #62601 to release/6.0

/cc @thaystg

Customer Impact

As VS tries to evaluate a lot of things while hover the mouse on variables while debugging, could be causing assert on runtime in the case of trying to evaluate in a static class that is in a loaded assembly but not added any breakpoint on it.

Testing

Unit tests and manual tests on Blazor.

Risk

Low Risk, only checking the debugId of the assembly and getting the correct one before send to debugger-agent.

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@ghost
Copy link

ghost commented Dec 14, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #62601 to release/6.0

/cc @thaystg

Customer Impact

As VS tries to evaluate a lot of things while hover the mouse on variables while debugging, could be causing assert on runtime in the case of trying to evaluate in a static class that is in a loaded assembly but not added any breakpoint on it.

Testing

Unit tests and manual tests on Blazor.

Risk

Low Risk, only checking the debugId of the assembly and getting the correct one before send to debugger-agent.

Author: thaystg
Assignees: thaystg
Labels:

Servicing-consider, area-Debugger-mono

Milestone: -

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to tactics approval.

@thaystg thaystg added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 20, 2021
@akoeplinger akoeplinger added this to the 6.0.x milestone Jan 18, 2022
@safern safern merged commit 2299c9f into dotnet:release/6.0 Feb 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants