-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant allocations from JsonSerializerOptions.GetConverter calls #65897
Closed
eiriktsarpalis
wants to merge
704
commits into
dotnet:main
from
eiriktsarpalis:fix-getconverter-allocations
Closed
Remove redundant allocations from JsonSerializerOptions.GetConverter calls #65897
eiriktsarpalis
wants to merge
704
commits into
dotnet:main
from
eiriktsarpalis:fix-getconverter-allocations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0635) * Fix stable builds for some transport packages Some non-shipping transport and sources packages were getting incorrectly getting stable versions. This didn't show up in the servicing excercise, though they probably did the right thing for unrelated reasons. * Fix transport package version by not using PackageVersion property on workloads-testing.targets Co-authored-by: Santiago Fernandez Madero <[email protected]>
* Don't special case "Experimental" projects We only have one experimental project, System.Runtime.Experimental and we want it to behave like any other package. * Make coreclr packages use `IsShipping` Co-authored-by: Eric StJohn <[email protected]>
…/runtime-assets dotnet/arcade (dotnet#60495) * Update dependencies from https://github.com/dotnet/runtime-assets build 20211015.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData From Version 6.0.0-beta.21514.1 -> To Version 6.0.0-beta.21515.1 * Update dependencies from https://github.com/dotnet/arcade build 20211015.3 Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk From Version 6.0.0-beta.21514.2 -> To Version 6.0.0-beta.21515.3 * Update dependencies from https://github.com/dotnet/icu build 20211015.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 6.0.0-rtm.21513.2 -> To Version 6.0.0-rtm.21515.1 * Update dependencies from https://github.com/dotnet/emsdk build 20211018.1 Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 From Version 6.0.0-rtm.21514.1 -> To Version 6.0.0 * Update dependencies from https://github.com/dotnet/emsdk build 20211018.2 Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 From Version 6.0.0-rtm.21514.1 -> To Version 6.0.0 * [wasm] Fix workload install for tests, with 6.0.0 Move to using the generated nuget.config, which has the feeds added by darc. The target is a duplicate from `src/installer/tests/PrepareTestAssets/PrepareTestAssets.proj`, and should be moved to a common location in future. Thanks to @lewing for the suggestion. * [wasm] Remove unused bits * Update dependencies from https://github.com/dotnet/runtime-assets build 20211018.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData From Version 6.0.0-beta.21514.1 -> To Version 6.0.0-beta.21518.1 * Update dependencies from https://github.com/dotnet/arcade build 20211019.3 Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk From Version 6.0.0-beta.21514.2 -> To Version 6.0.0-beta.21519.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Ankit Jain <[email protected]> Co-authored-by: Matt Mitchell <[email protected]>
…arget (dotnet#60695) * Tweak workload build to use _GenerateMsiVersionString target Replaces GenerateVersions that wasn't quite accurate enough for what we need * Pulled in arcade target that will be removed at a later date * More tweaks * Forget dependsontargets Co-authored-by: Steve Pfister <[email protected]>
…t#60684) * Update dependencies from https://github.com/dotnet/icu build 20211019.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 6.0.0-rtm.21515.1 -> To Version 6.0.0-rtm.21519.1 * Update dependencies from https://github.com/dotnet/emsdk build 20211020.1 Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 From Version 6.0.0 -> To Version 6.0.0 * Update dependencies from https://github.com/dotnet/emsdk build 20211020.3 Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 From Version 6.0.0 -> To Version 6.0.0 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…on CI (dotnet#59154) Backport of dotnet#58965 to release/6.0 This allows us to not run the CMake configure step separately for each libraries test suite which speeds up the build. Helps with dotnet#58549
…eturning to a wasm page. (dotnet#60777) * Fix loading a non wasm page and then returning to a wasm page. * Adding non-wasm-page.html * fixing other method * addressing @radical comments * adding last empty line Co-authored-by: DESKTOP-GEPIA6N\Thays <[email protected]>
…022.3 (dotnet#60783) Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk From Version 6.0.0-beta.21519.3 -> To Version 6.0.0-beta.21522.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
The VS4Mac team found two issues preventing them from successfully diagnosing VS4Mac failures on .NET: 1) Multiple "crashed" threads in the crash report json (dotnet#60932). 2) No flag or way to generate the crash report for hangs via the diagnostic server IPC commands (dotnet#60775). Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for VS4Mac. VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Change unknown signal exception type to 0. Issue: dotnet#60775 Fix how the load bias is calculate for shared modules Local testing with the SOS tests. VS4Mac team testing and verification. Low risk because it only affects createdump, dump IPC command and the runtime dump generation path.
Fix dotnet#57141 in windows build. Set the stack size (reserve) to 8MB, which is usually a default on linux. This way we should get similar behavior on windows. Co-authored-by: Radek Doulik <[email protected]>
The subset `host.pkg` is not producing the DotNetHost* NuGet packages. This is because the "Pack" target is getting invoked on the pkgprojs, but pkgprojs expect the "Build" target to be called. Since the "Pack" target is overriden in the Directory.Build.targets to be empty, no one is calling the "Build" target on the pkgprojs. In an official build, a later subset `packs.tests` comes through and builds `Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj`, which explicitly calls "Build" on the pkgprojs. So official builds still get these packages produced. In source-build, we are no longer building the `packs.tests` subset, so the packages are not produced. Co-authored-by: Eric Erhardt <[email protected]>
…es (dotnet#60835) * Revise descriptions of VS workloads, and add missing ones * typo Co-authored-by: Jo Shields <[email protected]>
…ity (dotnet#60881) * Disable package validation in source-build for reliability * Add tracking issue to comment * Switch from property overwrite to a condition
…ggregated COMWrappers RCW. (dotnet#61283) * Don't create a COM weak reference if the object is an aggregated COMWrappers RCW. * Add test for weak reference + aggregation with native weak reference impl. * Apply suggestions from code review Co-authored-by: Aaron Robinson <[email protected]> Co-authored-by: Jeremy Koritzinsky <[email protected]> Co-authored-by: Jeremy Koritzinsky <[email protected]> Co-authored-by: Aaron Robinson <[email protected]>
…61341) * Fix incorrect CCW decoding in GetObjectForCCW * Fix linux/mac build
* Fix for dotnet#60532 In stable package mode we should be setting CoreLib informational version to the ProductVersion according to the discussion on the issue thread. I have verified locally that this fixes the processinfo2 test for me that was previously failing in the StabilizePackageVersion mode. Please let me know how to proceed with the fix, whether you want me to just merge it into dotnet/runtime main, whether I should pursue its backport into 6.0 release and / or whether Matt considers cherry-picking my change to his stabilization PR. Thanks Tomas * Port InformationVersion fix to Mono corelib (dotnet#60614) dotnet#60572 for Mono's corelib. Co-authored-by: Tomas Rylek <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]>
* fix HttpClientHandlerTest.RemoteServer.cs * fix HttpClientHandlerTest.Authentication.cs * fix HttpClientHandlerTest.cs
….0-2022-02-08-1019 Merging internal commits for release/6.0
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Ulrich Weigand <[email protected]>
… the APIs required by Xamarin (dotnet#64556)
…net/icu (dotnet#64987) * Update dependencies from https://github.com/dotnet/arcade build 20220207.2 Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk From Version 2.5.1-beta.22104.4 -> To Version 2.5.1-beta.22107.2 * Update dependencies from https://github.com/dotnet/emsdk build 20220208.1 Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 From Version 6.0.0 -> To Version 6.0.2 * Update dependencies from https://github.com/dotnet/icu build 20220208.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 6.0.0-rtm.21519.1 -> To Version 6.0.0-rtm.22108.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ase/6.0 [release/6.0] Fix race condition in InteropSyncBlock for ComWrappers map.
* [release/6.0] Port ICU tests fix for server core x86 * Update src/libraries/System.Globalization/tests/IcuTests.cs Co-authored-by: Alexander Köplinger <[email protected]> * Add PlatformDetection.IsX86Process Co-authored-by: Tarek Mahmoud Sayed <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]>
Revert "[release/6.0] Fix ReadyToRun loading on Apple Silicon (dotnet#64104)"
eiriktsarpalis
requested review from
lambdageek,
vargaz,
BrzVlad,
naricc,
imhameed,
EgorBo,
SamMonoRT,
lateralusX,
thaystg,
marek-safar and
MichalStrehovsky
as code owners
February 25, 2022 16:33
Ugh, apologies for the spam everyone. gh cli seems to have bungled the base branch for this PR. |
ghost
locked as resolved and limited conversation to collaborators
Mar 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@(NativeFileReference)
([release/6.0] [wasm] Require workloads if using@(NativeFileReference)
#58290)dotnet
andhostpolicy
([release/6.0] Fix publishing symbols fordotnet
andhostpolicy
#58902)corehost_resolve_component_dependencies
andcorehost_set_error_writer
PInvokes in singlefile scenario. ([release/6.0] Overridecorehost_resolve_component_dependencies
andcorehost_set_error_writer
PInvokes in singlefile scenario. #60111).short
directive instead of.hword
([release/6.0] [AOT] Use.short
directive instead of.hword
#64637)Fixes Issue
main PR
Description
Customer Impact
Regression
Testing
Risk
Package authoring signed off?
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.