[release/6.0] [source-build][mono] Do not build Microsoft.NET.Runtime.MonoTargets.Sdk #63701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Does not build due to missing Microsoft.DotNet.CilStrip.Sources external dependency in source-build. * Package is not needed for source-build anyway.
leecow
added
Servicing-approved
safern
approved these changes
Feb 7, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #61607 to release/6.0
/cc @steveisok @uweigand
Customer Impact
Microsoft.NET.Runtime.MonoTargets.Sdk nuget package will not build for source build due to an external dependency not being available (Microsoft.DotNet.CilStrip.Sources). The MonoTargets package is not needed for source build anyway, so skipping it makes sense.
Testing
Manually confirmed that source build does not build this package.
Risk
Extremely low.