[release/6.0] Update zip extraction to never throw any exceptions when the LastWriteTime update fails #64192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsBackport of #63912 to release/6.0 /cc @adamsitnik @EatonZ Customer ImpactTestingRisk
|
danmoseley
approved these changes
Jan 25, 2022
ericstj
reviewed
Jan 25, 2022
...O.Compression.ZipFile/src/System/IO/Compression/ZipFileExtensions.ZipArchiveEntry.Extract.cs
Show resolved
Hide resolved
leecow
added
Servicing-approved
|
I appreciated the approval for a servicing release.👍 |
Scheduled for 2nd week of March. |
|
Failures are unrelated. System.Text.Json failure is: #61524 Diagnostics failure seems to be a machine in a bad state: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #63912 to release/6.0
/cc @adamsitnik @EatonZ
Customer Impact
After successful extraction to a file, the file handle is closed. After that, it's opened again to set the last write time. As reported by customer in #63912 some AV software can open it in the meantime and lock the access to the file. As the end result, Windows customers, who have AV software installed can sporadically observe an
IOException(ERROR_SHARING_VIOLATION).Testing
I was not able to reproduce this bug locally and I don't think that it's possible to implement a reliable test for it.
Risk
Can't see any.