Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Re-enable tests that call MakeGenericType with non-RuntimeType arguments #64344

Merged
merged 4 commits into from
Jan 27, 2022
Merged

[mono] Re-enable tests that call MakeGenericType with non-RuntimeType arguments #64344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28f7d09
[mono] Re-enable tests that call MakeGenericType with non-RuntimeType…
lambdageek Jan 26, 2022
96486f8
[wasm] Disable some logging generator tests
radical Jan 26, 2022
f61efba
[tvos] Disable some failing tests
radical Jan 26, 2022
8e3b314
Disable RegistrationBuilderTests that require ref emit on platforms t…
lambdageek Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ns/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratedCodeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

namespace Microsoft.Extensions.Logging.Generators.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
public class LoggerMessageGeneratedCodeTests
{
[Fact]
Expand Down
2 changes: 1 addition & 1 deletion ...tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorEmitterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Microsoft.Extensions.Logging.Generators.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52062", TestPlatforms.Browser)]
public class LoggerMessageGeneratorEmitterTests
{
[Fact]
Expand Down
2 changes: 1 addition & 1 deletion .../tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Microsoft.Extensions.Logging.Generators.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52062", TestPlatforms.Browser)]
public class LoggerMessageGeneratorParserTests
{
[Fact]
Expand Down
15 changes: 5 additions & 10 deletions ...stration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ public DiscoveredCatalog()
: base("") { }
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
public void ShouldSucceed()
{
var rb = new RegistrationBuilder();
Expand Down Expand Up @@ -174,8 +173,7 @@ private interface IGenericInterface<T> { }
[Export(typeof(IGenericInterface<>))]
private class ClassExportingInterface<T> : IGenericInterface<T> { }

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
public void GenericInterfaceExportInRegistrationBuilder()
{
CompositionContainer container = CreateRegistrationBuilderContainer(typeof(ClassExportingInterface<>));
Expand All @@ -188,8 +186,7 @@ private class GenericBaseClass<T> { }
[Export(typeof(GenericBaseClass<>))]
private class ClassExportingBaseClass<T> : GenericBaseClass<T> { }

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
public void GenericBaseClassExportInRegistrationBuilder()
{
CompositionContainer container = CreateRegistrationBuilderContainer(typeof(ClassExportingBaseClass<>));
Expand All @@ -211,8 +208,7 @@ public void GenericExportInRegistrationBuilder()
[Export(typeof(ExplicitGenericClass<>))]
private class ExplicitGenericClass<T> { }

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
public void ExplicitGenericExportInRegistrationBuilder()
{
CompositionContainer container = CreateRegistrationBuilderContainer(typeof(ExplicitGenericClass<>));
Expand All @@ -223,8 +219,7 @@ public void ExplicitGenericExportInRegistrationBuilder()
[Export(typeof(ExplicitGenericClass<,>))]
private class ExplicitGenericClass<T, U> { }

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
public void ExplicitGenericArity2ExportInRegistrationBuilder()
{
CompositionContainer container = CreateRegistrationBuilderContainer(typeof(ExplicitGenericClass<,>));
Expand Down