[mono] Re-enable tests that call MakeGenericType with non-RuntimeType arguments #64344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arguments Fixes dotnet#32743 The actual fix was in dotnet#58014
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
|
Replaces #64195 |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
approved these changes
Jan 26, 2022
eerhardt
approved these changes
Jan 26, 2022
akoeplinger
approved these changes
Jan 26, 2022
|
Some failures on wasm and tvOS. In both cases it looks like the tests probably need to be disabled. Wasm example. Looks like it's trying to find an assembly in the file system, which won't work: tvOS example. |
|
The wasm ones are failing to get the assembly location with |
`Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorEmitterTests.*` `Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.*` .. failing like: ``` [18:09:38] fail: [FAIL] Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.NotPartial [18:09:38] info: System.ArgumentException : Empty path name is not legal. (Parameter 'path') [18:09:38] info: at System.IO.Strategies.FileStreamHelpers.ValidateArguments(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize) [18:09:38] info: at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize) [18:09:38] info: at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) [18:09:38] info: at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync) [18:09:38] info: at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share) [18:09:38] info: at Roslyn.Utilities.StandardFileSystem.OpenFile(String filePath, FileMode mode, FileAccess access, FileShare share) [18:09:38] info: at Roslyn.Utilities.CommonCompilerFileSystemExtensions.OpenFileWithNormalizedException(ICommonCompilerFileSystem fileSystem, String filePath, FileMode fileMode, FileAccess fileAccess, FileShare fileShare) [18:09:38] info: at Microsoft.CodeAnalysis.MetadataReference.CreateFromFile(String path, MetadataReferenceProperties properties, DocumentationProvider documentation) [18:09:38] info: at SourceGenerators.Tests.RoslynTestUtils.CreateTestProject(IEnumerable`1 references, Boolean includeBaseReferences) [18:09:38] info: at SourceGenerators.Tests.RoslynTestUtils.RunGenerator(ISourceGenerator generator, IEnumerable`1 references, IEnumerable`1 sources, Boolean includeBaseReferences, CancellationToken cancellationToken) [18:09:38] info: at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.RunGenerator(String code, Boolean wrap, Boolean inNamespace, Boolean includeBaseReferences, Boolean includeLoggingReferences, CancellationToken cancellationToken) [18:09:38] info: at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.NotPartial() [18:09:38] info: --- End of stack trace from previous location --- ``` .. due to dotnet#52062 .
`System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderTests.ExplicitGenericExportInRegistrationBuilder` `System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderTests.ExplicitGenericArity2ExportInRegistrationBuilder` `System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderTests.GenericBaseClassExportInRegistrationBuilder` `System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderTests.GenericInterfaceExportInRegistrationBuilder` `System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderTests.ShouldSucceed` .. failing due to dotnet#32743 .
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
commented
Jan 27, 2022
| @@ -45,7 +45,7 @@ public DiscoveredCatalog() | |||
| } | |||
|
|
|||
| [Fact] | |||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)] | |||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestPlatforms.tvOS)] | |||
There was a problem hiding this comment.
@radical I don't think this is an ActiveIssue. (or at least 32743 is misleading). I don't think we can support MakeGenericType for non-RuntimeType types in FullAOT (without interpreter fallback).
I think this should be [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoAot))]
There was a problem hiding this comment.
Yep, this is not tvOS specific. Using RuntimeFeature.IsDynamicCode or whatever flag NativeAOT uses would be better
/cc @jkotas
There was a problem hiding this comment.
I guess that's
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported)]
Which brings up the question: do we run these tests with NativeAOT? I would expect them to fail there, too
There was a problem hiding this comment.
Which brings up the question: do we run these tests with NativeAOT?
Not yet. @MichalStrehovsky is working on increasing the test coverage for NativeAOT.
…hat don't support it
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failures are #64389 |
|
The re-enabled Perhaps, it's being tracked in #34582 |
MaximLipnin
added a commit
that referenced
this pull request
Jan 28, 2022
…LoggerMessageGeneratorEmitterTests with ActiveIssue (#64436) Addresses #64344 (comment) ... and skips System.Reflection.Emit.Tests.ModuleBuilderDefineInitializedData.DefineInitializedData_EnsureAlignmentIsMinimumNeededForUseOfCreateSpan test which requires reflection emit and fails on tvOS arm64 leg.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #32743
The actual fix was in #58014
Some of the re-enabled tests failed on wasm due to #52062, so those have been disabled here.