Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][windows] Disable Microsoft.Extensions.Logging.Generators.TestsLoggerMessageGeneratorEmitterTests with ActiveIssue #64436

Merged
merged 2 commits into from
Jan 28, 2022
Merged

[mono][windows] Disable Microsoft.Extensions.Logging.Generators.TestsLoggerMessageGeneratorEmitterTests with ActiveIssue #64436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f030298
[mono][windows] Disable Microsoft.Extensions.Logging.Generators.Tests…
MaximLipnin Jan 28, 2022
916178d
Skip DefineInitializedData_EnsureAlignmentIsMinimumNeededForUseOfCrea…
MaximLipnin Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorEmitterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
namespace Microsoft.Extensions.Logging.Generators.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/52062", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.IsMonoRuntime))]
public class LoggerMessageGeneratorEmitterTests
{
[Fact]
Expand Down
2 changes: 1 addition & 1 deletion ...ibraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineInitializedData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public void DefineInitializedData_CreateGlobalFunctionsCalled_ThrowsInvalidOpera
Assert.Throws<InvalidOperationException>(() => module.DefineInitializedData("MyField2", new byte[] { 1, 0, 1 }, FieldAttributes.Public));
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
public void DefineInitializedData_EnsureAlignmentIsMinimumNeededForUseOfCreateSpan()
{
ModuleBuilder module = Helpers.DynamicModule();
Expand Down