Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][windows] Disable Microsoft.Extensions.Logging.Generators.TestsLoggerMessageGeneratorEmitterTests with ActiveIssue #64436

Conversation

MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Jan 28, 2022

Addresses #64344 (comment)

... and skips System.Reflection.Emit.Tests.ModuleBuilderDefineInitializedData.DefineInitializedData_EnsureAlignmentIsMinimumNeededForUseOfCreateSpan test which requires reflection emit and fails on tvOS arm64 leg.

….LoggerMessageGeneratorEmitterTests with ActiveIssue
@ghost
Copy link

ghost commented Jan 28, 2022

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses #64344 (comment)

Author: MaximLipnin
Assignees: MaximLipnin
Labels:

area-Extensions-Logging

Milestone: -

@MaximLipnin
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaximLipnin
Copy link
Contributor Author

MaximLipnin commented Jan 28, 2022

The failure on tvOS arm64 is System.Reflection.Emit.Tests.ModuleBuilderDefineInitializedData.DefineInitializedData_EnsureAlignmentIsMinimumNeededForUseOfCreateSpan test introduced in #63430 and failing now with System.ExecutionEngineException : Attempting to JIT compile method 'intptr CheckType:LoadAddress4_1 ()' while running in aot-only mode

…teSpan which requires reflection emit on platforms that don't support it
@MaximLipnin
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaximLipnin MaximLipnin merged commit 82c45ca into dotnet:main Jan 28, 2022
@MaximLipnin MaximLipnin deleted the disable_LoggerMessageGeneratorEmitterTests_on_mono_windows branch January 28, 2022 14:22
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants