Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Port ICU tests fix for server core x86 #65038

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

safern
Copy link
Member

@safern safern commented Feb 9, 2022

icu is not present on Server Core in the SysWOW64.

Test only change to help get release branch CI green.

Branch is closed at the moment, but this can be merged when it is opened.

@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

icu is not present on Server Core in the SysWOW64.

Test only change to help get release branch CI green.

Branch is closed at the moment, but this can be merged when it is opened.

Author: safern
Assignees: safern
Labels:

area-System.Globalization

Milestone: -

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for keeping the tests healthy in servicing branches..

@safern
Copy link
Member Author

safern commented Feb 9, 2022

thanks for keeping the tests healthy in servicing branches..

Trying my best, with so many changes it's been a challenge but I think we are getting there.

@safern safern merged commit 5e65919 into dotnet:release/6.0 Feb 14, 2022
@safern safern deleted the PortIcuTestsFix60 branch February 14, 2022 18:34
@safern
Copy link
Member Author

safern commented Feb 14, 2022

Thanks, @akoeplinger for pushing the missing platform detection member.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants