-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relro, now and PIE for host and libraries #685
Conversation
The former core-setup and corefx native code build was missing the -z,relro and -z,now options and also the position independent related settings.
cc: @jeffschwMSFT, @lpereira |
It seems like this PR broke the Debug build of libraries WebAssembly.
Example: https://dev.azure.com/dnceng/public/_build/results?buildId=453500 |
The former core-setup and corefx native code build was missing the
-z,relro
and-z,now
options and also the position independent related-pie
linker option. This change fixes that by adding the missing optionsand using the native cmake position independent code support instead
of passing the respective compiler and linker options explicitly.
Close #632