WIP: Svm diamond shape without mono exclusion #70045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extends the svm_diamondshape test to exercise value types. As next step I'll work on testing the ldftn instruction. Thanks Tomas
1. TryToResolveStaticVirtualMethodOnThisType doesn't need the uniqueResolution flag - non-unique resolution on a single type (i.o.w. multiple MethodImpl records resolving the same MethodDecl) is always an error. 2. In getCallInfo, treat a SVM call as requiring runtime lookup when the constrained type is a canonical subtype. Thanks Tomas
As Michal pointed out, implementation of this call kind is quite similar to CORINFO_CALL_CODE_POINTER; initially I had trouble making it work but now the rest of the change is working fine it turns out that CORINFO_CALL_CODE_POINTER works fine so I removed the new kind I had originally introduced. Thanks Tomas
trylek
added
the
NO-MERGE
SamMonoRT
approved these changes
Jun 1, 2022
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #66887 without the issues.targets entry to validate whether Mono works now that #69738 has been merged in.