Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Fix some racy tests #73524

Merged
merged 15 commits into from
Aug 9, 2022
Merged

Commits on Aug 7, 2022

  1. [wasm][debugger] Don't log the full content of OnJsEventRaised as that

    .. contains the assembly contents which can be large .
    radical committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    0d4631c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    835e98c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac5bb6c View commit details
    Browse the repository at this point in the history
  4. [wasm][debugger] HotReload tests - Add better ways to check for when

    .. the updated method becomes callable, instead of `Thread.Sleep`.
    radical committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    9eb93ea View commit details
    Browse the repository at this point in the history
  5. [wasm][debugger] Throw a useful message in the test so it's easier to…

    … spot in test failures
    radical committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    3a78f8f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7b4722e View commit details
    Browse the repository at this point in the history
  7. [wasm][debugger][tests] Use ConcurrentDictionary for event listeners,

    .. and notification handlers, since they can be modified from different
    threads.
    
    Fixes dotnet#69144 .
    radical committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    f6d561b View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Configuration menu
    Copy the full SHA
    e0a335b View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. [wasm][debugger] Wait for the test app to be ready before calling

    .. methods, from the tests.
    
    Fixes dotnet#73528 .
    radical committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b05719a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2da98f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3518306 View commit details
    Browse the repository at this point in the history
  4. Allow tests to run only after we get both events - Mono.runtimeReady,…

    … and #debugger-app-ready#
    radical committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b580cda View commit details
    Browse the repository at this point in the history
  5. [wasm][debugger] Firefox tests fix

    - ChromeProvider starts the browser and then waits for a special string
    which indicates that the browser is ready for connections.
    
    - Firefox doesn't emit anything similar, so it waits for `console.log: ready`
    message we get from `debugger-driver.html`.
      - but since we wait for this in `FirefoxProvider`, when we start the
      `Inspector` after this, the ready message is already gone, so it will
      never see it.
    
      - To avoid this, if we change the connection logic to instead
        a. start the browser
        b. wait till we can connect successfully
        c. and then start `Inspector`, then it can still be too late if
        the page starts up, and the message is emitted before the Inspector
        was started.
    
    - A proper fix would be to start the browser but with no url specified.
    And once we establish a connection to it, *then* send a command to open
    a url.
    
    For now, we'll emit the old message `console.log: ready` too, just for
    consumption by the firefox tests. And this can be fixed property in the
    future.
    radical committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    d6de429 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    26fd3da View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0e25252 View commit details
    Browse the repository at this point in the history