-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Fix some racy tests #73524
Commits on Aug 7, 2022
-
[wasm][debugger] Don't log the full content of OnJsEventRaised as that
.. contains the assembly contents which can be large .
Configuration menu - View commit details
-
Copy full SHA for 0d4631c - Browse repository at this point
Copy the full SHA 0d4631cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 835e98c - Browse repository at this point
Copy the full SHA 835e98cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac5bb6c - Browse repository at this point
Copy the full SHA ac5bb6cView commit details -
[wasm][debugger] HotReload tests - Add better ways to check for when
.. the updated method becomes callable, instead of `Thread.Sleep`.
Configuration menu - View commit details
-
Copy full SHA for 9eb93ea - Browse repository at this point
Copy the full SHA 9eb93eaView commit details -
[wasm][debugger] Throw a useful message in the test so it's easier to…
… spot in test failures
Configuration menu - View commit details
-
Copy full SHA for 3a78f8f - Browse repository at this point
Copy the full SHA 3a78f8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b4722e - Browse repository at this point
Copy the full SHA 7b4722eView commit details -
[wasm][debugger][tests] Use ConcurrentDictionary for event listeners,
.. and notification handlers, since they can be modified from different threads. Fixes dotnet#69144 .
Configuration menu - View commit details
-
Copy full SHA for f6d561b - Browse repository at this point
Copy the full SHA f6d561bView commit details
Commits on Aug 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e0a335b - Browse repository at this point
Copy the full SHA e0a335bView commit details
Commits on Aug 9, 2022
-
[wasm][debugger] Wait for the test app to be ready before calling
.. methods, from the tests. Fixes dotnet#73528 .
Configuration menu - View commit details
-
Copy full SHA for b05719a - Browse repository at this point
Copy the full SHA b05719aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2da98f9 - Browse repository at this point
Copy the full SHA 2da98f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3518306 - Browse repository at this point
Copy the full SHA 3518306View commit details -
Allow tests to run only after we get both events - Mono.runtimeReady,…
… and #debugger-app-ready#
Configuration menu - View commit details
-
Copy full SHA for b580cda - Browse repository at this point
Copy the full SHA b580cdaView commit details -
[wasm][debugger] Firefox tests fix
- ChromeProvider starts the browser and then waits for a special string which indicates that the browser is ready for connections. - Firefox doesn't emit anything similar, so it waits for `console.log: ready` message we get from `debugger-driver.html`. - but since we wait for this in `FirefoxProvider`, when we start the `Inspector` after this, the ready message is already gone, so it will never see it. - To avoid this, if we change the connection logic to instead a. start the browser b. wait till we can connect successfully c. and then start `Inspector`, then it can still be too late if the page starts up, and the message is emitted before the Inspector was started. - A proper fix would be to start the browser but with no url specified. And once we establish a connection to it, *then* send a command to open a url. For now, we'll emit the old message `console.log: ready` too, just for consumption by the firefox tests. And this can be fixed property in the future.
Configuration menu - View commit details
-
Copy full SHA for d6de429 - Browse repository at this point
Copy the full SHA d6de429View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26fd3da - Browse repository at this point
Copy the full SHA 26fd3daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e25252 - Browse repository at this point
Copy the full SHA 0e25252View commit details