Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Avoid duplicate jobs in runtime-wasm #74837

Merged
merged 3 commits into from
Aug 31, 2022
Merged

[wasm] Avoid duplicate jobs in runtime-wasm #74837

merged 3 commits into from
Aug 31, 2022

Conversation

radical
Copy link
Member

@radical radical commented Aug 30, 2022 •
edited
Loading

  • In runtime-wasm, skip the jobs that already run in runtime pipeline
  • Add wasm jobs to runtime-extra-platforms only in rolling builds
  • Remove EAT from runtime-extra-platforms on rolling builds, because it is already in runtime

This will help remove duplication of Wasm.Build.Tests, among others, which is helix-heavy.

@radical radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it arch-wasm WebAssembly architecture labels Aug 30, 2022
@ghost ghost assigned radical Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

NO-MERGE, NO-REVIEW, arch-wasm
Milestone: -

@ghost
Copy link

ghost commented Aug 30, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

NO-MERGE, NO-REVIEW, arch-wasm, area-Infrastructure-libraries
Milestone: -

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 30, 2022

/azp run runtime-wasm,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines failed to run 2 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@radical radical changed the title [IGNORE][wasm] testing ci improvements [wasm] Avoid duplicate jobs in runtime-wasm Aug 31, 2022
@radical radical added area-Infrastructure-mono and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-Infrastructure-libraries labels Aug 31, 2022
@radical radical marked this pull request as ready for review August 31, 2022 01:04
@ghost
Copy link

ghost commented Aug 31, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
  • In runtime-wasm, skip the jobs that already run in runtime pipeline
  • Add wasm jobs to runtime-extra-platforms only in rolling builds

This will help remove duplication of Wasm.Build.Tests, among others, which is helix-heavy.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

steveisok
steveisok approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoeplinger we should do something similar with android and ios

@radical radical mentioned this pull request Aug 31, 2022
Closed
@radical
Copy link
Member Author

radical commented Aug 31, 2022

Libraries Build OSX arm64 Debug, and mono llvmfullaot Pri0 Runtime Tests Run Linux arm64 release have been stuck at checkout 3 hours. Since, they are unrelated to this PR, I'm going to merge.

@radical radical merged commit 51f3ca6 into dotnet:main Aug 31, 2022
@radical radical deleted the just-ci-test branch August 31, 2022 04:32
@radical radical mentioned this pull request Aug 31, 2022
Open
23 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@lewing lewing lewing approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @lewing @steveisok