Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Split runtime-wasm pipeline into runtime-wasm-libtests, and runtime-wasm-non-libtests #74859

Merged
merged 5 commits into from
Aug 31, 2022

Conversation

radical
Copy link
Member

@radical radical commented Aug 31, 2022

Adds two new pipelines:

  • runtime-wasm-libtests - runs all the wasm library tests
  • runtime-wasm-non-libtests - runs all the wasm non-library tests like WBT, debugger etc.

And runtime-wasm runs the combination of the two above.

  • For all 3 pipelines, jobs are run only if they weren't run on the default (runtime) pipeline

Which pipeline should I run?

  • if runtime didn't run the tests that would be useful for testing the changes, then:
    • If the changes only relate to libraries, the runtime, then use runtime-wasm-libtests
    • If the changes only affect Wasm.Build.Tests, or debugger tests, or runtime tests, then use runtime-wasm-non-libtests
    • Use runtime-wasm when you want to run all the wasm tests

Updated CI matrix for wasm

PR:

  • only-pc means only on relevant path changes

Run by default

  • runtime runs jobs only when relevant paths change. And for AOT, only smoke tests are run.
. runtime
libtests linux+windows: all, only-pc
libtests eat linux+windows: smoke, only-pc
libtests aot linux+windows: smoke, only-pc
high resource aot none
Wasm.Build.Tests linux+windows: only-pc
Debugger tests linux+windows: only-pc
Runtime tests linux+windows: only-pc

Run manually with /azp run ..

  • runtime-wasm* pipelines are triggered manually, and they only run the jobs that would not run on any default pipelines based on path changes.
  • The AOT jobs run only smoke tests on runtime, and on runtime-wasm* pipelines all the AOT tests are run.
. runtime-wasm runtime-wasm-libtests runtime-wasm-non-libtests
libtests linux+windows: all linux+windows: all none
libtests eat linux: all linux: all none
libtests aot linux+windows: all linux+windows: all none
high resource aot linux+windows: all linux+windows: all none
Wasm.Build.Tests linux+windows none linux+windows
Debugger tests linux+windows none linux+windows
Runtime tests linux none linux
Perftrace linux: all tests linux: all tests
Multi-thread linux: all tests linux: all tests
  • runtime-extra-platforms does not run any wasm jobs on PRs
  • high resource aot runs a few specific library tests with AOT, that require more memory to AOT.

Rolling build (twice a day):

  • runtime runs all the wasm jobs, but AOT still only runs smoke tests.
  • runtime-extra-platforms also runs by default. And it runs only the cases not covered by runtime.
. runtime runtime-extra-platforms (always run)
libtests linux+windows: all none
libtests eat linux: all none
libtests aot linux+windows: smoke linux+windows: all
high resource aot none linux+windows: all
Wasm.Build.Tests linux+windows none
Debugger tests linux+windows none
Runtime tests linux none
Perftrace linux: build only none
Multi-thread linux: build only none
  • high resource aot runs a few specific library tests with AOT, that require more memory to AOT.

@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Aug 31, 2022
@ghost
Copy link

ghost commented Aug 31, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

@radical radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 31, 2022
@ghost ghost assigned radical Aug 31, 2022
@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm-libtests,runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm-libtests,runtime-wasm,runtime-wasm-non-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm-libtests,runtime-wasm,runtime-wasm-non-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@radical radical force-pushed the wasm-libtests-ci branch 3 times, most recently from a4bf18d to 9669e83 Compare August 31, 2022 09:42
@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm-libtests,runtime-wasm,runtime-wasm-non-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm-libtests,runtime-wasm,runtime-wasm-non-libtests,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@radical radical changed the title [wasm] Split runtime-wasm pipeline [wasm] Split runtime-wasm pipeline into runtime-wasm-libtests, and runtime-wasm-non-libtests Aug 31, 2022
@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm-libtests,runtime-wasm,runtime-wasm-non-libtests,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 31, 2022

/azp run runtime-wasm-libtests,runtime-wasm,runtime-wasm-non-libtests,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@radical radical marked this pull request as ready for review August 31, 2022 10:55
@radical radical removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 31, 2022
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't love the runtime-wasm-non-libtests name but I couldn't come up with a better name either :)

@radical
Copy link
Member Author

radical commented Aug 31, 2022

LGTM. I don't love the runtime-wasm-non-libtests name but I couldn't come up with a better name either :)

And we might end up doing more splits, depending on usage :)

@radical radical merged commit c30cfbb into dotnet:main Aug 31, 2022
@radical radical deleted the wasm-libtests-ci branch August 31, 2022 19:39
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants