Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes an issue with gradual decommit in scenarios where we have … #84975

Merged
merged 3 commits into from
May 22, 2023

Commits on Apr 18, 2023

  1. This fixes an issue with gradual decommit in scenarios where we have …

    …almost exclusively background GCs.
    
    The problem is that we turn off the gradual_decommit_in_progress_p flag and rely on the distribute_free_regions flag to turn it back on. If we only trigger a BGC however, distribute_free_regions won't get called and the flag will stay off, despite the global_regions_to_decommit list being non-empty.
    
    This will cause regions to accumulate in the global_regions_to_decommit list, and eventual will cause the process to run out of memory.
    PeterSolMS committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    c709db6 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Configuration menu
    Copy the full SHA
    c42d3c3 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Instead of saving and restoring gradual_decommit_in_progress_p, just …

    …test for the no gc region case in decommit_step.
    PeterSolMS committed May 16, 2023
    Configuration menu
    Copy the full SHA
    3ecbb28 View commit details
    Browse the repository at this point in the history