Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes an issue with gradual decommit in scenarios where we have … #84975

Merged
merged 3 commits into from
May 22, 2023
Merged

This fixes an issue with gradual decommit in scenarios where we have … #84975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c709db6
This fixes an issue with gradual decommit in scenarios where we have …
PeterSolMS Apr 18, 2023
c42d3c3
Merge branch 'main' into Fix_issue_78959
PeterSolMS May 15, 2023
3ecbb28
Instead of saving and restoring gradual_decommit_in_progress_p, just …
PeterSolMS May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/coreclr/gc/gc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6847,7 +6847,6 @@ void gc_heap::gc_thread_function ()
END_TIMING(suspend_ee_during_log);

proceed_with_gc_p = TRUE;
gradual_decommit_in_progress_p = FALSE;

if (!should_proceed_with_gc())
{
Expand Down Expand Up @@ -41450,6 +41449,12 @@ void gc_heap::decommit_ephemeral_segment_pages()
// return true if we actually decommitted anything
bool gc_heap::decommit_step (uint64_t step_milliseconds)
{
if (settings.pause_mode == pause_no_gc)
{
// don't decommit at all if we have entered a no gc region
return false;
}

size_t decommit_size = 0;

#ifdef USE_REGIONS
Expand Down