Fix calling existing ctor with MethodInvoker; share tests with invokers #90796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue Details[verifying tests]
|
This was referenced Aug 18, 2023
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Aug 20, 2023
This was referenced Aug 20, 2023
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
IDisposable
reviewed
Aug 21, 2023
src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvokerCommon.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 22, 2023
This was referenced Aug 22, 2023
|
CI failures in runtime-extra-platforms appear consistent with other recent PRs including #90836 and #90864. Created some known issues to help filter the errors in the future. Also, there's some infra work needed so failures running runtime-extra-platforms show all of the unknown failures (currently just the first 4 are shown). |
|
/backport to release/8.0 |
1 similar comment
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5945904726 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the existing
MethodInfo\ConstructorInfotests so they can also run under the new invoker classesMethodInvoker\ConstructorInvoker; they are run in both a forced-interpreted and a forced-emit mode for additional coverage.This uncovered two edge case issues (fixed in this PR) that only affect the new invoker classes that were added in Preview 7:
MethodInvokernow works as expected: theobjparameter's constructor is invoked andnullis returned; this is consistent withConstructorInfo.Invoke(obj, ...)MemberAccessException(same exception type used for similar cases). Calling static constructors can still be done withConstructorInfobut since that is rare, adds overhead, and is not supported on NativeAOT, support wasn't added toMethodInvokerorConstructorInvoker.No tests were removed except for the invoker test "ExistingInstance()" which was already covered in the shared tests.
These changes should be ported to v8\RC2 since they only affect the new APIs added in Preview 7 and will avoid a breaking change in v9.