Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for generic structs in "needs marshalling" check #90836

Merged
merged 11 commits into from
Sep 1, 2023
Merged

Check for generic structs in "needs marshalling" check #90836

merged 11 commits into from
Sep 1, 2023

Conversation

jtschuster
Copy link
Member

Fixes #90828.

@ghost ghost assigned jtschuster Aug 18, 2023
@jkotas
Copy link
Member

jkotas commented Aug 18, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky
jkoritzinsky reviewed Aug 19, 2023
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a negative test that throws InvalidProgramException with a generic class type?

This was referenced Aug 19, 2023
Closed
Open
Closed
Open
Closed
Open
Closed
Open
@jtschuster
Copy link
Member Author

Can we add a negative test that throws InvalidProgramException with a generic class type?

I don't think we can, the analyzer will create an error for classes and structs with NonBlittable generic parameters.

@jtschuster
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Aug 22, 2023
Closed
@steveharter steveharter mentioned this pull request Aug 22, 2023
Merged
@jtschuster @jkoritzinsky
Update src/coreclr/vm/dllimport.cpp
8e66f37 
Co-authored-by: Jeremy Koritzinsky <[email protected]>
@jtschuster
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Aug 31, 2023
Closed
3 tasks
@jtschuster jtschuster merged commit 737d85a into dotnet:main Sep 1, 2023
165 of 177 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@jtschuster jtschuster

Labels
area-Interop-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blittability check doesn't account for generic structs
4 participants
@jtschuster @jkotas @jkoritzinsky @AaronRobinsonMSFT