Error out when NativeLib has EventPipe enabled #90811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsEventPipe does not work correctly with native AOT library (#89346). We will generate an error when
|
agocke
reviewed
Aug 18, 2023
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated
Show resolved
Hide resolved
…e.Publish.targets Co-authored-by: Andy Gocke <[email protected]>
elinor-fung
reviewed
Aug 18, 2023
| @@ -50,6 +50,7 @@ | |||
| Text="RuntimeIdentifier is required for native compilation. Try running dotnet publish with the -r option value specified." /> | |||
| <Error Condition="'$(GeneratePackageOnBuild)' == 'true'" Text="GeneratePackageOnBuild is not supported for native compilation." /> | |||
| <Error Condition="'$(OutputType)' != 'Library' and '$(NativeLib)' != '' and '$(CustomNativeMain)' != 'true'" Text="NativeLib requires OutputType=Library." /> | |||
| <Error Condition="'$(NativeLib)' != '' and '$(EventSourceSupport)' == 'true'" Text="EventSource is not supported when compiling to a native library. Set EventSourceSupport to false." /> | |||
There was a problem hiding this comment.
Should we update the native AOT diagnostics doc you added to call out that it is not supported for native libraries?
There was a problem hiding this comment.
I'm not sure on this one, as in this is too much of a corner case to call out on the official documentation and this error should be sufficient enough.
jkotas
approved these changes
Aug 18, 2023
jkotas
reviewed
Aug 18, 2023
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Show resolved
Hide resolved
…e.Publish.targets Co-authored-by: Jan Kotas <[email protected]>
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5941905358 |
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Sep 7, 2023
This reverts commit e811599.
MichalStrehovsky
added a commit
that referenced
this pull request
Sep 14, 2023
Works around #89346. We blocked event pipe completely in shared libraries in #90811 but: * Elinor found out the shutdown problem is actually Windows specific, so blocking Linux (our most important target) is unnecessary. * We can avoid the hang at the cost of corrupting the ongoing event pipe session by just not doing the shutdown. This can be worked around by simply stopping the event pipe session at dotnet-trace side manually. I validated the shared library scenario no longer hangs at shutdown with this. #89346 still tracks if we can do better here.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
This reverts commit e811599.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventPipe does not work correctly with native AOT library (#89346). We will generate an error when
EventSourceSupportproperty is set for native aot library.