[release/8.0] Error out when NativeLib has EventPipe enabled #90934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…e.Publish.targets Co-authored-by: Andy Gocke <[email protected]>
…e.Publish.targets Co-authored-by: Jan Kotas <[email protected]>
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #90811 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
agocke
approved these changes
Aug 22, 2023
jeffschwMSFT
approved these changes
Aug 22, 2023
agocke
added
Servicing-approved
|
@carlossanlop can you merge when you get a chance? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90811 to release/8.0
/cc @agocke @LakshanF
Customer Impact
There is an active issue causing a hang when EventSource is used inside a native library, as opposed to an executable. The fix will not make into .NET 8.
This change adds an error to the SDK if EventSource is enabled and the project is compiling to a native library, avoiding the runtime hang.
Testing
Manual testing. An SDK test can be added when this flows to the dotnet/sdk repo.
Risk
Very low. Simple change to the Native AOT publish targets.