BigInteger constructor perf #91176

Rob-Hague · 2023-08-27T14:53:27Z

Use BinaryPrimitives/MemoryMarshal in BigInteger constructor

Method	Job	ByteCount	IsBigEndian	Mean	Error	StdDev	Ratio
Ctor	pr	5	False	13.28 ns	0.073 ns	0.065 ns	1.05
Ctor	main	5	False	12.60 ns	0.067 ns	0.063 ns	1.00

Ctor	pr	5	True	16.38 ns	0.036 ns	0.032 ns	1.32
Ctor	main	5	True	12.37 ns	0.016 ns	0.013 ns	1.00

Ctor	pr	16	False	11.78 ns	0.019 ns	0.018 ns	0.66
Ctor	main	16	False	17.72 ns	0.113 ns	0.094 ns	1.00

Ctor	pr	16	True	15.08 ns	0.059 ns	0.055 ns	0.84
Ctor	main	16	True	17.90 ns	0.015 ns	0.012 ns	1.00

Ctor	pr	64	False	13.78 ns	0.022 ns	0.019 ns	0.31
Ctor	main	64	False	44.43 ns	0.040 ns	0.036 ns	1.00

Ctor	pr	64	True	17.45 ns	0.027 ns	0.021 ns	0.39
Ctor	main	64	True	44.82 ns	0.040 ns	0.033 ns	1.00

Ctor	pr	256	False	22.16 ns	0.020 ns	0.017 ns	0.15
Ctor	main	256	False	150.99 ns	0.240 ns	0.213 ns	1.00

Ctor	pr	256	True	28.29 ns	0.031 ns	0.027 ns	0.18
Ctor	main	256	True	153.63 ns	0.862 ns	0.806 ns	1.00

public class Benchmark
{
    [Params(5, 16, 64, 256)]
    public int ByteCount;

    [Params(true, false)]
    public bool IsBigEndian;

    private byte[] _bytes;

    [GlobalSetup]
    public void Setup()
    {
        Random r = new(123);
        _bytes = new byte[ByteCount];
        do
        {
            r.NextBytes(_bytes);
            // Use positive benchmark values for consistency
        } while (_bytes[0] is not (> 0 and < 0x80) || _bytes[^1] is not (> 0 and < 0x80));
    }

    [Benchmark] public BigInteger Ctor() => new BigInteger(_bytes, isBigEndian: IsBigEndian);
}

ghost · 2023-08-27T14:53:40Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Use BinaryPrimitives/MemoryMarshal in BigInteger constructor


BenchmarkDotNet v0.13.7, Windows 11 (10.0.22621.2134/22H2/2022Update/SunValley2)
AMD Ryzen 7 5700U with Radeon Graphics, 1 CPU, 16 logical and 8 physical cores
.NET SDK 8.0.100-preview.7.23376.3
  [Host]     : .NET 7.0.4 (7.0.423.11508), X64 RyuJIT AVX2
  pr : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
  main : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2

Method	Job	ByteCount	IsBigEndian	Mean	Error	StdDev	Median	Ratio	RatioSD
Ctor	pr	5	False	16.87 ns	0.201 ns	0.178 ns	16.87 ns	1.12	0.01
Ctor	main	5	False	15.11 ns	0.051 ns	0.045 ns	15.10 ns	1.00	0.00

Ctor	pr	5	True	10.35 ns	0.050 ns	0.044 ns	10.34 ns	0.82	0.00
Ctor	main	5	True	12.68 ns	0.026 ns	0.020 ns	12.67 ns	1.00	0.00

Ctor	pr	16	False	11.39 ns	0.010 ns	0.008 ns	11.39 ns	0.63	0.01
Ctor	main	16	False	17.95 ns	0.370 ns	0.396 ns	17.66 ns	1.00	0.00

Ctor	pr	16	True	12.75 ns	0.268 ns	0.251 ns	12.74 ns	0.71	0.01
Ctor	main	16	True	17.86 ns	0.132 ns	0.103 ns	17.82 ns	1.00	0.00

Ctor	pr	64	False	25.55 ns	0.151 ns	0.118 ns	25.50 ns	0.48	0.01
Ctor	main	64	False	53.89 ns	0.894 ns	0.836 ns	54.34 ns	1.00	0.00

Ctor	pr	64	True	22.35 ns	0.036 ns	0.030 ns	22.36 ns	0.50	0.00
Ctor	main	64	True	44.86 ns	0.049 ns	0.038 ns	44.84 ns	1.00	0.00

Ctor	pr	256	False	48.89 ns	0.062 ns	0.058 ns	48.87 ns	0.27	0.00
Ctor	main	256	False	183.99 ns	0.502 ns	0.419 ns	183.79 ns	1.00	0.00

Ctor	pr	256	True	60.14 ns	0.115 ns	0.096 ns	60.11 ns	0.39	0.00
Ctor	main	256	True	153.37 ns	0.081 ns	0.068 ns	153.36 ns	1.00	0.00

    public class Benchmark
    {
        [Params(5, 16, 64, 256)]
        public int ByteCount;

        [Params(true, false)]
        public bool IsBigEndian;

        private byte[] _bytes;

        [GlobalSetup]
        public void Setup()
        {
            Random r = new(123);
            _bytes = new byte[ByteCount];
            r.NextBytes(_bytes);
        }

        [Benchmark] public BigInteger Ctor() => new BigInteger(_bytes, isBigEndian: IsBigEndian);
    }

Author:	Rob-Hague
Assignees:	-
Labels:	`area-System.Numerics`
Milestone:	-

src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs

adamsitnik

Overall it LGTM, but I would prefer another set of eyes that is more familiar with endianness conversion to confirm that.

@Rob-Hague thank you for your contribution!

src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs

stephentoub · 2023-10-31T14:26:21Z

/azp list

azure-pipelines · 2023-10-31T14:26:29Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-staging runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-android-grpc-client-tests runtime-wasm-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-tools-tests runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional runtime-nativeaot-outerloop

stephentoub · 2023-10-31T14:26:52Z

/azp run runtime-community

azure-pipelines · 2023-10-31T14:27:09Z

Azure Pipelines successfully started running 1 pipeline(s).

stephentoub · 2023-10-31T14:40:46Z

src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs

-
-                // Copy all dwords, except don't do the last one if it's not a full four bytes
-                int curDword, curByte;
+                int wholeDwordCount = Math.DivRem(byteCount, 4, out int unalignedBytes);


Should we use:

(uint wholeUInt32Count, uint unalignedBytes) = Math.DivRem((uint)byteCount, 4);

instead, since we know here byteCount isn't negative?

If we did, then we would have to cast the values back to int in each of the AsSpan and Slice calls. What do you suggest?

Rob-Hague · 2023-10-31T19:43:38Z

Commenting the runtime-community build link in case it disappears when I push

https://dev.azure.com/dnceng-public/public/_build/results?buildId=456533&view=results

adamsitnik · 2023-11-02T07:17:11Z

/azp run runtime-community

azure-pipelines · 2023-11-02T07:17:25Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik

LGTM, the s390x failures are unrelated (they are being addressed by #94333)

EgorBo · 2023-11-07T16:37:44Z

Perf improvement:

[Perf] Windows/x64: 1 Improvement on 11/3/2023 8:29:06 PM perf-autofiling-issues#24245
[Perf] Linux/x64: 2 Improvements on 11/3/2023 3:59:21 PM perf-autofiling-issues#24176
[Perf] Windows/x64: 1 Improvement on 11/3/2023 8:29:06 PM perf-autofiling-issues#24194

Use BinaryPrimitives/MemoryMarshal in BigInteger constructor

cdad4c6

dotnet-issue-labeler bot added the area-System.Numerics label Aug 27, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 27, 2023

MichalPetryka reviewed Aug 27, 2023

View reviewed changes

src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs Outdated Show resolved Hide resolved

Rob-Hague added 2 commits August 28, 2023 20:47

Revert MemoryMarshal use

388ed17

Use MemoryMarshal in the other direction

4b21dfa

build-analysis bot mentioned this pull request Aug 29, 2023

[8.0] [mono] Test process gets killed #90834

Closed

huoyaoyuan reviewed Sep 1, 2023

View reviewed changes

src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs Outdated Show resolved Hide resolved

huoyaoyuan mentioned this pull request Sep 6, 2023

Use Unsafe.WriteUnaligned in BitConverter.GetBytes #91639

Closed

Merge remote-tracking branch 'upstream/main' into bigintctor

0528c69

adamsitnik reviewed Oct 30, 2023

View reviewed changes

src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs Outdated Show resolved Hide resolved

adamsitnik requested a review from stephentoub October 30, 2023 17:07

adamsitnik self-assigned this Oct 30, 2023

adamsitnik added the tenet-performance Performance related issue label Oct 30, 2023

Merge remote-tracking branch 'upstream/main' into bigintctor

6e11d85

stephentoub reviewed Oct 31, 2023

View reviewed changes

Dword -> UInt32

e7f12af

adamsitnik approved these changes Nov 3, 2023

View reviewed changes

adamsitnik merged commit 5becf0f into dotnet:main Nov 3, 2023
112 of 115 checks passed

Rob-Hague deleted the bigintctor branch November 3, 2023 14:53

EgorBo mentioned this pull request Nov 9, 2023

[Perf] Windows/arm64: 2 Improvements on 11/6/2023 11:45:15 PM dotnet/perf-autofiling-issues#24310

Closed

kotlarmilos mentioned this pull request Nov 13, 2023

[Perf] Linux/x64: 2 Improvements on 11/3/2023 3:59:21 PM dotnet/perf-autofiling-issues#24218

Closed

ghost locked as resolved and limited conversation to collaborators Dec 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BigInteger constructor perf #91176

BigInteger constructor perf #91176

Rob-Hague commented Aug 27, 2023 •

edited

Loading

ghost commented Aug 27, 2023

adamsitnik left a comment

stephentoub commented Oct 31, 2023

azure-pipelines bot commented Oct 31, 2023

stephentoub commented Oct 31, 2023

azure-pipelines bot commented Oct 31, 2023

stephentoub Oct 31, 2023

Rob-Hague Oct 31, 2023

Rob-Hague commented Oct 31, 2023

adamsitnik commented Nov 2, 2023

azure-pipelines bot commented Nov 2, 2023

adamsitnik left a comment

EgorBo commented Nov 7, 2023 •

edited by cincuranet

Loading

BigInteger constructor perf #91176

BigInteger constructor perf #91176

Conversation

Rob-Hague commented Aug 27, 2023 • edited Loading

ghost commented Aug 27, 2023

adamsitnik left a comment

Choose a reason for hiding this comment

stephentoub commented Oct 31, 2023

azure-pipelines bot commented Oct 31, 2023

stephentoub commented Oct 31, 2023

azure-pipelines bot commented Oct 31, 2023

stephentoub Oct 31, 2023

Choose a reason for hiding this comment

Rob-Hague Oct 31, 2023

Choose a reason for hiding this comment

Rob-Hague commented Oct 31, 2023

adamsitnik commented Nov 2, 2023

azure-pipelines bot commented Nov 2, 2023

adamsitnik left a comment

Choose a reason for hiding this comment

EgorBo commented Nov 7, 2023 • edited by cincuranet Loading

Rob-Hague commented Aug 27, 2023 •

edited

Loading

EgorBo commented Nov 7, 2023 •

edited by cincuranet

Loading