Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing endianness issues on S390x #94333

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

giritrivedi
Copy link
Contributor

Taking care of endianness issues on s390x architecture for newly introduced test cases.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 3, 2023
@ghost
Copy link

ghost commented Nov 3, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

Taking care of endianness issues on s390x architecture for newly introduced test cases.

Author: giritrivedi
Assignees: -
Labels:

area-System.Reflection.Emit, community-contribution

Milestone: -

Taking care of endianness issues on s390x architecture
for newly introduced test cases.
@adamsitnik
Copy link
Member

/azp run runtime-community

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Take care of endianness issue for newly written test cases
on s390x architecture.
@adamsitnik
Copy link
Member

/azp run runtime-community

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@giritrivedi
Copy link
Contributor Author

Failures are unrelated to the changes..

@giritrivedi giritrivedi marked this pull request as ready for review November 3, 2023 11:22
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit ede2cb2 into dotnet:main Nov 3, 2023
112 of 115 checks passed
@adamsitnik adamsitnik added the arch-s390x Related to s390x architecture (unsupported) label Nov 6, 2023
@giritrivedi giritrivedi deleted the EndianessIssue branch November 22, 2023 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-s390x Related to s390x architecture (unsupported) area-System.Reflection.Emit community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants