-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use add_link_options
and target_link_options
in cmake
#92844
Conversation
There's a slight UX difference between the Also the way you specify the
|
The remaining failures on Windows look like they're in the RC-only targets. Right now these targets remove linker flags that they are not compatible with. Instead, we can update the |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFixes #92843 Replaces
|
add_linker_options
and target_linker_options
in cmakeadd_link_options
and target_link_options
in cmake
Failure looks like #93527 |
Looks like this broke the official build
|
This got broken in #92844, it was missing the scope keyword.
…tnet#92844)" This reverts commit 3086d8a.
@jtschuster, @jkoritzinsky, @jkotas it also accidentally enabled CETCOMPAT for executables (e.g. corerun.exe). |
Fixes #92843
Replaces
add_linker_flag
withadd_linker_options
andtarget_linker_options
, where possible.