Fix target_link_options in pgosupport.cmake #93670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got broken in #92844, it was missing the scope keyword.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis got broken in #92844, it was missing the scope keyword.
|
lewing
approved these changes
Oct 18, 2023
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Oct 18, 2023
I noticed that we wrote the cache file before invoking cmake, this meant that if the cmake configure step failed (e.g. because of an invalid command like in dotnet#93670) then running the build again would skip cmake configure, resulting in a broken build setup. This only applies to non-VS generators like ninja.
|
This is not tested in public CI so merging to fix the official build. |
akoeplinger
added a commit
that referenced
this pull request
Oct 18, 2023
I noticed that we wrote the cache file before invoking cmake, this meant that if the cmake configure step failed (e.g. because of an invalid command like in #93670) then running the build again would skip cmake configure, resulting in a broken build setup. This only applies to non-VS generators like ninja.
jkotas
added a commit
to jkotas/runtime
that referenced
this pull request
Oct 23, 2023
This reverts commit fa0ba15.
jkotas
added a commit
that referenced
this pull request
Oct 23, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken in #92844, it was missing the scope keyword.