Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not contain out-of-bounds local addresses #99195

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Mar 2, 2024

These are not supported by the emitter. Also handles the case where the offset may overflow past the UINT16_MAX limit (similarly imposed by the emitter).

Fixes #98971.

Some diffs expected where we don't contain stuff like IND<long>(LCL_VAR_ADDR V00<int>) anymore. These arise mostly from promoted fields.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 2, 2024
@ghost
Copy link

ghost commented Mar 2, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

WIP.

These are not supported by the emitter. Also handles the case where the offset may overflow past the UINT16_MAX limit (similarly imposed by the emitter).

Fixes #98971.

Some diffs expected where we don't contain stuff like IND<long>(LCL_VAR_ADDR V00<int>) anymore.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review March 3, 2024 18:26
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the assert!

@TIHan
Copy link
Contributor

TIHan commented Mar 5, 2024

Thank you!

@TIHan TIHan merged commit 0df43f2 into dotnet:main Mar 5, 2024
139 checks passed
@SingleAccretion SingleAccretion deleted the Valid-Lcl-Addr branch March 12, 2024 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: JIT/Regression/JitBlue/Runtime_63942/Runtime_63942/Runtime_63942.cmd
3 participants