-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling of copying resource assemblies from NuGet packages during publish #774
Comments
Potential workaround for now: <Target Name="RemoveSatellitesFromPublish" AfterTargets="ComputeFilesToPublish">
<ItemGroup>
<ResolvedFileToPublish Remove="@(ReferenceSatellitePaths)" />
</ItemGroup>
</Target> |
Workaround doesn't seem to work as the host fails if any assemblies listed in the deps.json aren't present:
Seems we'd have to update the build target to trim them out of the deps.json file too. |
@kieranmo suggested having a property to set the desired language outputs (like ClickOnce), so that only resources for those languages would be included. I like that idea. <PropertyGroup>
<SatelliteResourceLanguages>en-US</SatelliteResourceLanguages>
</PropertyGroup> |
dsplaisted
added a commit
to dsplaisted/sdk
that referenced
this issue
Mar 13, 2018
…urceLanguages property Fixes dotnet#774
dsplaisted
added a commit
to dsplaisted/sdk
that referenced
this issue
Mar 13, 2018
…urceLanguages property Fixes dotnet#774
Yay!!! |
dsplaisted
added a commit
to dsplaisted/sdk
that referenced
this issue
Mar 23, 2018
…urceLanguages property Fixes dotnet#774
mmitche
pushed a commit
to mmitche/sdk
that referenced
this issue
Jun 5, 2020
…712.5 (dotnet#774) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19362.5
asmichi
added a commit
to asmichi/ChildProcess
that referenced
this issue
Aug 31, 2021
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Many NuGet packages (including those shipped by Microsoft) include localized resource satellite assemblies in the main package. This can greatly inflate the publish output size of a typical ASP.NET Core application (like https://github.com/aspnet/live.asp.net) for no benefit in the cases where localized resources from such packages aren't desired or needed.
In this case, the publish output size grows from 12 MB to 26 MB due to the resource assemblies.
It would be great to have an MSBUILD property that could be set in the application's project file to disable copying of satellite assemblies from NuGet references to the publish folder.
The text was updated successfully, but these errors were encountered: