-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SBRPs to enable PVP flow for templating repo #608
Conversation
Is there a reason why templating can't be on the latest version of NuGet? |
Good question. The templating repo currently has the version managed by dependabot: https://github.com/dotnet/templating/blob/985dfbb1fe2e578dd70f5923600093e668e49327/eng/dependabot/Packages.props#L15-L17 It was being overriden by source-build with this configuration: https://github.com/dotnet/templating/blob/985dfbb1fe2e578dd70f5923600093e668e49327/eng/Package.props#L17-L19 But with the PVP changes, those versions don't get applied here, so we're left with the default. |
Closing this in preference to the changes in dotnet/templating#6360. |
Reopening this instead of using the changes in dotnet/templating#6360 because templating requires that preview versions of the |
I agree with this. Generally, when I see use of stable package versions, and I know that these aren't being used for functionality in the build or being re-disted (e.g. Microsoft.NET.Compilers.Toolset), I think they are good candidates for SBRP. |
Adds the following packages:
This required manual workarounds for dotnet/source-build#3364 and dotnet/sdk#31655.
Contributes to dotnet/source-build#3043