Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SBRPs to enable PVP flow for templating repo #608

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Apr 6, 2023

Adds the following packages:

  • NuGet.Common.6.5.0
  • NuGet.Configuration.6.5.0
  • NuGet.Credentials.6.5.0
  • NuGet.Frameworks.6.5.0
  • NuGet.Packaging.6.5.0
  • NuGet.Protocol.6.5.0
  • NuGet.Versioning.6.5.0

This required manual workarounds for dotnet/source-build#3364 and dotnet/sdk#31655.

Contributes to dotnet/source-build#3043

@MichaelSimons
Copy link
Member

Is there a reason why templating can't be on the latest version of NuGet?

@mthalman
Copy link
Member Author

mthalman commented Apr 6, 2023

Is there a reason why templating can't be on the latest version of NuGet?

Good question. The templating repo currently has the version managed by dependabot: https://github.com/dotnet/templating/blob/985dfbb1fe2e578dd70f5923600093e668e49327/eng/dependabot/Packages.props#L15-L17

It was being overriden by source-build with this configuration: https://github.com/dotnet/templating/blob/985dfbb1fe2e578dd70f5923600093e668e49327/eng/Package.props#L17-L19

But with the PVP changes, those versions don't get applied here, so we're left with the default.

@mthalman
Copy link
Member Author

mthalman commented Apr 7, 2023

Closing this in preference to the changes in dotnet/templating#6360.

@mthalman mthalman closed this Apr 7, 2023
@mthalman
Copy link
Member Author

@mthalman mthalman enabled auto-merge (squash) April 13, 2023 19:37
@mmitche
Copy link
Member

mmitche commented Apr 13, 2023

I agree with this. Generally, when I see use of stable package versions, and I know that these aren't being used for functionality in the build or being re-disted (e.g. Microsoft.NET.Compilers.Toolset), I think they are good candidates for SBRP.

@mthalman mthalman merged commit b3c60d8 into dotnet:main Apr 14, 2023
@mthalman mthalman deleted the nuget branch April 14, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants