Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NuGet to dependency flow #6360

Closed
wants to merge 2 commits into from
Closed

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Apr 7, 2023

Problem

When attempting to enable PVP flow for the templating repo, it was discovered that the repo has a dependency on the previously released version of NuGet (6.5.0) rather than the in-development version (6.6.0). This would require SBRPs to be defined for those package versions. Instead, it seems more appropriate to update the repo to enable dependency flow for NuGet.

Solution

I've enabled dependency flow for NuGet.Credentials (for the VS 17.6 channel). Since the versions are consistent across the NuGet packages, I've reused that version for the other NuGet dependent packages that are also referenced.

Once merged, I'll create a darc subscription with the following settings:

https://github.com/nuget/nuget.client (VS 17.6) ==> 'https://github.com/dotnet/templating' ('main')
  - Update Frequency: EveryBuild
  - Enabled: True
  - Batchable: False
  - PR Failure Notification tags:
  - Merge Policies: Standard

@mmitche
Copy link
Member

mmitche commented Apr 7, 2023

@vlada-shubina What do you think?

IIRC, some of these versions actually make it into the templates themselves. That may mean that they might need to stay at an old, stable version rather than picking up the live version.

@vlada-shubina
Copy link
Member

@vlada-shubina What do you think?

IIRC, some of these versions actually make it into the templates themselves. That may mean that they might need to stay at an old, stable version rather than picking up the live version.

We decided not to use the latest version for NuGet for two reasons:

  • (main reason) latest NuGet packages are not available on NuGet.org which makes preview and in some cases release template engine NuGet packages pushed to NuGet.org unusable
  • we had issues with having different versions in dotnet/sdk and dotnet/templating

To accept this PR, we need to ensure that NuGet NuGet packages are always pushed to NuGet.org together with .NET packages which wasn't the case with .NET 7.

Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To accept this PR, we need to ensure that preview NuGet.* packages are pushed to nuget.org

@mthalman
Copy link
Member Author

To accept this PR, we need to ensure that preview NuGet.* packages are pushed to nuget.org

Based on this information, I'll abandon these changes and go ahead with adding these NuGet packages to SBRP: dotnet/source-build-reference-packages#608.

@mthalman mthalman closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants