Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Nuget.Commands and Nuget.Credentials 6.2.2 #697

Conversation

oleksandr-didyk
Copy link
Contributor

Fixes product pre-builts introduced by dotnet/installer#16592 by adding Nuget.Commands and Nuget.Credentials 6.2.2

log.txt Outdated Show resolved Hide resolved
@MichaelSimons
Copy link
Member

Have you verified Arcade is not loading these? Given arcade is a toolset repo, there is a good chance they are.

@oleksandr-didyk
Copy link
Contributor Author

oleksandr-didyk commented Jun 6, 2023

Have you verified Arcade is not loading these? Given arcade is a toolset repo, there is a good chance they are.

Viktor disabled bundling of Nuget.* packages with Arcade's projects as mentioned in #673 (comment). That was the original reason we could use SBRPed Nuget for Arcade.

I will test it out with the VMR just to be safe

@MichaelSimons
Copy link
Member

Viktor disabled bundling of Nuget.* packages with Arcade's projects as mentioned in #673 (comment). That was the original reason we could use SBRPed Nuget for Arcade.

Yes but technically it is possible for a nuget package to reference 6.2.2 which would load the SBRP.

@oleksandr-didyk
Copy link
Contributor Author

I will test it out with the VMR just to be safe

The build passed, Nuget* pre-builts are not present

@oleksandr-didyk oleksandr-didyk merged commit 9eb0813 into dotnet:main Jun 6, 2023
@oleksandr-didyk oleksandr-didyk deleted the add-nuget-commands-credentials-6-2-2 branch June 7, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants