Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up SUPPORTS_WINDOWSIDENTITY in S.P.SM.csproj #2006

Closed
zhenlan opened this issue Jun 28, 2017 · 1 comment
Closed

Clean up SUPPORTS_WINDOWSIDENTITY in S.P.SM.csproj #2006

zhenlan opened this issue Jun 28, 2017 · 1 comment
Assignees
@mconnew
Labels
infrastructure Issues related to the build, packaging, testing or related areas.
Milestone
S120

Comments

@zhenlan
Copy link
Member

zhenlan commented Jun 28, 2017

We should remove section below in S.P.SM.csproj

  <PropertyGroup Condition="'$(TargetGroup)' != 'netcore50' AND '$(TargetsWindows)' == 'true'">
    <DefineConstants>$(DefineConstants);SUPPORTS_WINDOWSIDENTITY</DefineConstants>
  </PropertyGroup>

SUPPORTS_WINDOWSIDENTITY should be true for both Windows and Linux except UWP. We already have it defined correctly in another section in the same file, but above section is causing confusion.

cc: @mconnew
@zhenlan zhenlan added the infrastructure Issues related to the build, packaging, testing or related areas. label Jun 28, 2017
@zhenlan zhenlan added this to the S120 milestone Jun 28, 2017
@zhenlan zhenlan mentioned this issue Jun 28, 2017
Merged
@shmao
Copy link
Contributor

shmao commented Jul 7, 2017

This was fixed by #2043.

@shmao shmao closed this as completed Jul 7, 2017
@zhenlan zhenlan assigned mconnew and unassigned shmao Jul 7, 2017
imcarolwang added a commit to imcarolwang/wcf that referenced this issue Nov 26, 2019
@imcarolwang
Fix xUnit warning dotnet#2006 for test projects.
c5819dc
StephenBonikowsky added a commit that referenced this issue Nov 26, 2019
@StephenBonikowsky
Merge pull request #4055 from imcarolwang/fix_xUnitWarning_2006
f8550be 
Fix xUnit warning #2006 for test projects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mconnew mconnew

Labels
infrastructure Issues related to the build, packaging, testing or related areas.
Projects
None yet
Milestone
S120
Development

No branches or pull requests
4 participants
@mconnew @zhenlan @StephenBonikowsky @shmao