-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix System.Private.ServiceModel.dll's Uapaot Build. #2012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the C# changes, but build changes LGTM.
@dagood Thanks for reviewing the PR. Do you have any ideas about the following error,
The tests passed. But testResults.xml couldn't be found. |
Those are CI issues I'm working on, don't block your merge on it. |
LGTM, although I'd like to know more about the code we stripped out, I can follow-up offline. |
@dotnet-bot test ci please |
@StephenBonikowsky The removed classes were added because they were not available on netcore50, so we make a internal copy of the framework type. As the types are available in NS2.0, we can remove them. Otherwise, the build would complain about ambiguous types. |
</ItemGroup> | ||
|
||
<PropertyGroup Condition="'$(TargetGroup)' != 'netcore50' AND '$(TargetsWindows)' == 'true'"> | ||
<PropertyGroup Condition="'$(TargetGroup)' != 'uap' AND '$(TargetsWindows)' == 'true'"> | ||
<DefineConstants>$(DefineConstants);SUPPORTS_WINDOWSIDENTITY</DefineConstants> | ||
</PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please remove this section? #2006
@dotnet-bot test all outerloop please |
@dotnet-bot test all innerloop please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shmao!
I made the following changes
uapaot-Windows_NT
from System.Private.ServiceModel/src/Configurations.props. We should be able to use the uap build for uapaot. We used to havenetcore50
only.netcore50
withuap
in System.Private.ServiceModel.csprojFix #2001
Fix #2002
Fix #2003
Fix #2005