Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not violated xUnit warnings in wcf test projects. #4011

Conversation

imcarolwang
Copy link
Contributor

Address part of issue #4006.

WCF test projects doesn't violate below xunit warnings, so I removed the suppress config from related csproj files in this single PR.
xUnit1003
xUnit1006
xUnit1013
xUnit1014
xUnit2006
xUnit2010

For the other violations listed below, will address each in separated PR.
xUnit2000
xUnit2009
xUnit1024
xUnit2013

@imcarolwang imcarolwang self-assigned this Oct 31, 2019
@StephenBonikowsky
Copy link
Member

CI checks are failing for same reason as I explained in #4010

@StephenBonikowsky
Copy link
Member

Considering what this PR is doing I'm going to go ahead and merge.

@StephenBonikowsky StephenBonikowsky merged commit 73f2caf into dotnet:master Oct 31, 2019
@StephenBonikowsky StephenBonikowsky mentioned this pull request Oct 31, 2019
12 tasks
@imcarolwang imcarolwang deleted the Remove_Unaffected_xUnitWarningsSuppress branch November 22, 2019 01:51
@StephenBonikowsky StephenBonikowsky added the NET Core 3.1 Release Issues for the NET Core 3.1 release. label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NET Core 3.1 Release Issues for the NET Core 3.1 release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants