-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useComboBox always grabbing focus on render #1574
Comments
Agreed, this is a problem for me too. Certainly looks to be attributable to the 8.3.1 -> 8.3.2 update. |
This is also bugged on Enregistrement.de.l.ecran.2024-02-29.a.17.34.50.mov |
Will fix this one tomorrow unless someone else creates a PR first.
…On Thu, 29 Feb 2024 at 18:35, Julien BONNIN ***@***.***> wrote:
This is also bugged on useSelect, we updated our dropdown to use
Downshift 8.3.2 and now it focuses the last dropdown on the page (and
scrolls it into view):
https://sparkui.vercel.app/?path=/docs/components-dropdown--docs
https://github.com/downshift-js/downshift/assets/2033710/78033851-54ed-4e12-bb61-b7e8a054b8db
—
Reply to this email directly, view it on GitHub
<#1574 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWAZAACEGMHE6G72LNGMELYV5MFRAVCNFSM6AAAAABD5XEF2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRGUZDAMBTG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
🎉 This issue has been resolved in version 8.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
downshift
version: 8.3.2node
version: v18.19.0npm
(oryarn
) version: 10.2.3Relevant code or config
What you did:
What happened: Since useRef returns an object the if statment will always be true
Reproduction repository:
Problem description: When rendered the component always grabs focus
Suggested solution:
if (isInitialMount)
->if (isInitialMount.current)
The text was updated successfully, but these errors were encountered: