fix: fixes issue causing combobox to grab focus on render #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1575 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1746 1746
Branches 528 528
=========================================
Hits 1746 1746 ☔ View full report in Codecov by Sentry. |
|
Would say this is the simplest solution. Another way if you dont want to disable eslint for that line is to change the useIsIninitalMount to return the ref instead of the current value. Then it would be a stable reference in the dependency array. |
|
Let's keep it like that, for now. Thanks! |
|
@all-contributors please add @FredrikMWold for code, bug |
|
🎉 This PR is included in version 8.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: fixes issue causing combobox to grab focus on render
Why: Closes: #1574
How: The latest release adds
isInitalMountto the dependency array. Whichs causes it to rerender whenisInitialMountis set to false and triggering.focus.Checklist: