Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge new main.py and updated config handling into dev #72

Merged
merged 19 commits into from
Mar 6, 2023
Merged

Conversation

famosab
Copy link
Member

@famosab famosab commented Mar 4, 2023

This PR covers log files #42, a more accessible config file #55, better user-interface #57 and a more flexible main.py #46.

@famosab famosab requested a review from GwennyGit March 4, 2023 12:12
@famosab famosab mentioned this pull request Mar 4, 2023
Copy link
Collaborator

@GwennyGit GwennyGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files look fine. I found some minor issues like typos within the code files which I will fix immediately. Regarding the documentation, I think the code highlighting might cause some issues for colour-blind people. Thus, I changed the colours which I will commit after this comment. The colours were tested with the Chrome web browser add-on Spectrum. Another issue I just realised with the documentation is that we have again highlighting of visited internal links in the sidebar on the right side of the web page. However, this does not seem to be easily solvable. Shall we leave that for now?
After I added the two commits for the code highlighting in the documentation and the typos, I think we can merge everything into main.

@famosab famosab merged commit fa322cd into dev Mar 6, 2023
@famosab famosab deleted the config-update branch March 6, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants