GH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same resul… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ GitHub issue apache#41433 could not be retrieved. |
… result on x86 and Arm (apache#41434) ### Rationale for this change Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127. ### What changes are included in this PR? 1. Added type cast to signed char to save existing x86 behavior on Arm platform. 2. Added tests cases for negative results. ### Are these changes tested? UT included. ### Are there any user-facing changes? None * GitHub Issue: apache#41433 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
xxlaykxx
approved these changes
May 3, 2024
| @@ -1377,7 +1377,7 @@ gdv_int32 ascii_utf8(const char* data, gdv_int32 data_len) { | |||
| if (data_len == 0) { | |||
| return 0; | |||
| } | |||
| return static_cast<gdv_int32>(data[0]); | |||
| return static_cast<gdv_int32>(static_cast<signed char>(data[0])); | |||
There was a problem hiding this comment.
should we try changing the method signature to be const signed char * insead?
There was a problem hiding this comment.
It won't build then as "some text" is const char and compiler has some strict validations for that. I have already tried.
lriggs
approved these changes
May 3, 2024
DenisTarasyuk
merged commit ae1df93
into
dremio:dremio_25.0_15.0.1
42 of 82 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t on x86 and Arm (apache#41434)
Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.
What changes are included in this PR?
Are these changes tested?
UT included.
Are there any user-facing changes?
None
Authored-by: DenisTarasyuk [email protected]