Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same resul… #71

Merged
merged 1 commit into from
May 3, 2024
Merged

GH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same resul… #71

merged 1 commit into from
May 3, 2024

Commits on May 2, 2024

  1. apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same… 

    … result on x86 and Arm (apache#41434)

### Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

### What changes are included in this PR?

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

### Are these changes tested?
UT included.

### Are there any user-facing changes?
None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
    @DenisTarasyuk
    DenisTarasyuk committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b0e9720 View commit details
    Browse the repository at this point in the history