You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We now need to reconcile Artifact and ArtifactCommand classes.
This ticket is about moving the functionality of the Artifact to ArtifactCommand.
Please note that there is be a follow-up ticket to replace the logger with monolog.
Solution direction.
Merge the functionality of Artifact to ArtifactCommand. The Artifact::artifact() should become ArtifactCommand::processArtifact() and be called from ArtifactCommand::execute().
Update `ArtifactCommand::execute() to correctly return exit codes on exception.
The code should look like:
The text was updated successfully, but these errors were encountered:
AlexSkrypnyk
changed the title
Simplify ArtifactCommand and move dependencies into Artifact class
Move functionality from Artifact class to ArtifactCommand class
Mar 11, 2024
…s. (#80)
* Move functionality from Artifact class to ArtifactCommand class.
* Update coverage test name.
* Check branch exisiting before do remove.
* Revert to standard app entry
#42 allows us to further improve the architecture of this package.
BLOCKED by #64
We now need to reconcile
Artifact
andArtifactCommand
classes.This ticket is about moving the functionality of the
Artifact
toArtifactCommand
.Please note that there is be a follow-up ticket to replace the logger with
monolog
.Solution direction.
Merge the functionality of
Artifact
toArtifactCommand
. TheArtifact::artifact()
should becomeArtifactCommand::processArtifact()
and be called fromArtifactCommand::execute()
.Update `ArtifactCommand::execute() to correctly return exit codes on exception.
The code should look like:
The text was updated successfully, but these errors were encountered: