You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add trait to the ArtifactCommand class and replace all calls to the $this->output->write() with calls to the logging trait's functions.
Review and update existing Functional tests to assert that output messages are present in the output. They may also be present and no updates are required. Note: we already have a CLI command runner test helper runGitArtifactCommand() that deals with running the artifact executable and allows to assert for the output.
Review and update existing testReport() to make sure that all of the logged messages are present in the report.
Add/update Functional tests to assert that output messages are present in the output. Note: we already have a CLI command runner test helper runGitArtifactCommand() that deals with running the artifact executable and allows to assert for the output, so it should be a matter of updating existing tests. It may also be a case that tests should not be updated because they already
The text was updated successfully, but these errors were encountered:
Blocked by:
Artifact
class toArtifactCommand
class #76We need to use a centralised logging solution that would:
For logger, the solution is to use
https://github.com/Seldaek/monolog
as a logger with support of the logging formatters described in https://github.com/Seldaek/monolog/blob/main/doc/02-handlers-formatters-processors.md#formattersNote that
monolog
uses log levels set via-v|vv|vvv
to output messages:Solution direction
monolog/monolog
as a dependencyLogTrait.php
(for re-usability between projects). Example code below - please adjust as necessary:ArtifactCommand
class and replace all calls to the$this->output->write()
with calls to the logging trait's functions.runGitArtifactCommand()
that deals with running the artifact executable and allows to assert for the output.testReport()
to make sure that all of the logged messages are present in the report.Add/update Functional tests to assert that output messages are present in the output. Note: we already have a CLI command runner test helper
runGitArtifactCommand()
that deals with running the artifact executable and allows to assert for the output, so it should be a matter of updating existing tests. It may also be a case that tests should not be updated because they alreadyThe text was updated successfully, but these errors were encountered: