Adds missing return type to collect_traces function
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 1213 1228 +15
Branches 154 154
=========================================
+ Hits 1213 1228 +15
Continue to review full report at Codecov.
|
sobolevn
requested changes
Jun 27, 2020
typesafety/test_primitives/test_tracing/test_collect_traces.yml
Outdated
Show resolved
Hide resolved
Now we pass `collect_traces` directly to `contextmanager` function at end of file to avoid return type problems.
sobolevn
requested changes
Jun 29, 2020
typesafety/test_primitives/test_tracing/test_collect_traces.yml
Outdated
Show resolved
Hide resolved
thepabloaguilar
force-pushed
the
bug/add-return-type-collect-traces
branch
from
5b9e980
to
bb5dae2
Compare
To fix type hint errors we separate all the possible `collect_traces` function signatures using `@overload` decorator The implementation of `collect_traces`, now, acts like a factory!
thepabloaguilar
force-pushed
the
bug/add-return-type-collect-traces
branch
from
bb5dae2
to
329475d
Compare
sobolevn
requested changes
Jun 30, 2020
…tead of passing `factory` through the `contextmanager` function
…collect_traces_context_manager_return_type_two` case
|
I was wrong in this explanation, in fact it's just a PyCharm error/warning!
I've made the modification to use |
sobolevn
approved these changes
Jul 1, 2020
|
Thanks a lot for the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #441
closes #443