-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds missing return type to collect_traces
function
#442
Merged
sobolevn
merged 11 commits into
dry-python:master
from
thepabloaguilar:bug/add-return-type-collect-traces
Jul 1, 2020
Merged
Adds missing return type to collect_traces
function
#442
sobolevn
merged 11 commits into
dry-python:master
from
thepabloaguilar:bug/add-return-type-collect-traces
Jul 1, 2020
Commits on Jun 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 515f440 - Browse repository at this point
Copy the full SHA 515f440View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f88a48 - Browse repository at this point
Copy the full SHA 5f88a48View commit details
Commits on Jun 29, 2020
-
Removes
@contextmanager
decorator fromcollect_traces
functionNow we pass `collect_traces` directly to `contextmanager` function at end of file to avoid return type problems.
Configuration menu - View commit details
-
Copy full SHA for 05c1bcb - Browse repository at this point
Copy the full SHA 05c1bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 275c0a1 - Browse repository at this point
Copy the full SHA 275c0a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf68d80 - Browse repository at this point
Copy the full SHA cf68d80View commit details
Commits on Jun 30, 2020
-
To fix type hint errors we separate all the possible `collect_traces` function signatures using `@overload` decorator The implementation of `collect_traces`, now, acts like a factory!
Configuration menu - View commit details
-
Copy full SHA for 7e50f7b - Browse repository at this point
Copy the full SHA 7e50f7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c39150a - Browse repository at this point
Copy the full SHA c39150aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 329475d - Browse repository at this point
Copy the full SHA 329475dView commit details
Commits on Jul 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8c274c9 - Browse repository at this point
Copy the full SHA 8c274c9View commit details -
Changes
factory
function to use the@contextmanager
decorator ins……tead of passing `factory` through the `contextmanager` function
Configuration menu - View commit details
-
Copy full SHA for 7f8736e - Browse repository at this point
Copy the full SHA 7f8736eView commit details -
Updates safety tests of
collect_traces
function, specifically the `……collect_traces_context_manager_return_type_two` case
Configuration menu - View commit details
-
Copy full SHA for 95db932 - Browse repository at this point
Copy the full SHA 95db932View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.