Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing return type to collect_traces function #442

Merged

Commits on Jun 27, 2020

  1. Configuration menu
    Copy the full SHA
    515f440 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f88a48 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Removes @contextmanager decorator from collect_traces function

    Now we pass `collect_traces` directly to `contextmanager` function at end of file to avoid return type problems.
    thepabloaguilar committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    05c1bcb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    275c0a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cf68d80 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Modifies tracing.py

    To fix type hint errors we separate all the possible `collect_traces` function signatures using `@overload` decorator
    The implementation of `collect_traces`, now, acts like a factory!
    thepabloaguilar committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    7e50f7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c39150a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    329475d View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Configuration menu
    Copy the full SHA
    8c274c9 View commit details
    Browse the repository at this point in the history
  2. Changes factory function to use the @contextmanager decorator ins…

    …tead of passing `factory` through the `contextmanager` function
    thepabloaguilar committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    7f8736e View commit details
    Browse the repository at this point in the history
  3. Updates safety tests of collect_traces function, specifically the `…

    …collect_traces_context_manager_return_type_two` case
    thepabloaguilar committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    95db932 View commit details
    Browse the repository at this point in the history