Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc: AppVeyor status badge does reflect tests that fail #1012

Closed
johlju opened this issue Jan 10, 2018 · 2 comments · Fixed by #1013
Closed

SqlServerDsc: AppVeyor status badge does reflect tests that fail #1012

johlju opened this issue Jan 10, 2018 · 2 comments · Fixed by #1013
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Jan 10, 2018

Details of the scenario you tried and the problem that is occurring:
Latest merge into dev failed to pass the tests, but the status badge still shows the tests passing.

@kwirkykat can you see if the token changed in AppVeyor when we renamed the repository? Previous token was mxn453y284eab8li.

You can see a badge image URL and sample markup on the Badges tab of project settings. Badge URLs for both private and public projects contain a security token.
https://www.appveyor.com/docs/status-badges/

image

The reason for the tests to fail was because of the timing issue submitted in issue #1008.
@johlju johlju added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels Jan 10, 2018
@kwirkykat
Copy link
Contributor

@johlju Yes it did change. New token is b3g8f7kftx64n26l

@johlju
Copy link
Member Author

johlju commented Jan 10, 2018

@kwirkykat Thanks! I will update the README.md with the new token.

/cc @PlagueHO another thing to verify when you rename "your" resource modules.

johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 10, 2018
@johlju
Changes to SqlServerDsc
4562b8a 
- Fix new security token for AppVeyor status badge in README.md. When we renamed
  the repository the security token was changed (issue dsccommunity#1012).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 10, 2018
@johlju
Changes to SqlServerDsc
42866f8 
- Updated the security token for AppVeyor status badge in README.md. When we
  renamed the repository the security token was changed (issue dsccommunity#1012).
@johlju johlju mentioned this issue Jan 10, 2018
Merged
5 tasks
johlju added a commit that referenced this issue Jan 11, 2018
@johlju
SqlServerDsc: Updated the security token for AppVeyor status badge (#…
6d3b959 
…1013)

- Changes to SqlServerDsc
  - Updated the security token for AppVeyor status badge in README.md. When we
    renamed the repository the security token was changed (issue #1012).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Updated the security token for AppVeyor status badge johlju/SqlServerDsc
2 participants
@kwirkykat @johlju