Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Updated the security token for AppVeyor status badge #1013

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 10, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #1012

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

- Updated the security token for AppVeyor status badge in README.md. When we
  renamed the repository the security token was changed (issue dsccommunity#1012).
@johlju johlju changed the title Changes to SqlServerDsc SqlServerDsc: Updated the security token for AppVeyor status badge Jan 10, 2018
@johlju
Copy link
Member Author

johlju commented Jan 10, 2018

Now it seems it will work correctly again.

image

@codecov-io
Copy link

codecov-io commented Jan 10, 2018

Codecov Report

Merging #1013 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1013   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        32      32           
  Lines      3914    3914           
====================================
  Hits       3827    3827           
  Misses       87      87

@johlju johlju added the needs review The pull request needs a code review. label Jan 10, 2018
@johlju
Copy link
Member Author

johlju commented Jan 11, 2018

:LGTM:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 6d3b959 into dsccommunity:dev Jan 11, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jan 20, 2018
@johlju johlju deleted the fix-token-in-readme branch March 12, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: AppVeyor status badge does reflect tests that fail
2 participants