Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlWaitForAG: Update unit tests to use the same (newest) unit test template #1088

Closed
johlju opened this issue Mar 14, 2018 · 1 comment · Fixed by #1100
Closed

SqlWaitForAG: Update unit tests to use the same (newest) unit test template #1088

johlju opened this issue Mar 14, 2018 · 1 comment · Fixed by #1100
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Mar 14, 2018

Details of the scenario you tried and the problem that is occurring

The unit tests for this resource is using an old unit test template.
Suggest we update the unit tests to use the latest unit test template.

https://github.com/PowerShell/DscResources/blob/master/Tests.Template/unit_template.ps1

The DSC configuration that is using the resource (as detailed as possible)

n/a

Version of the operating system and PowerShell the target node is running

n/a

SQL Server edition and version the target node is running

n/a

What SQL Server PowerShell modules, and which version, are present on the target node.

n/a

Version of the DSC module you're using, or write 'dev' if you're using current dev branch

Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. easy fix good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Mar 14, 2018
@TraGicCode
Copy link
Contributor

i'm starting this now.

@TraGicCode TraGicCode mentioned this issue Apr 3, 2018
Merged
1 task
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 3, 2018
johlju pushed a commit that referenced this issue Apr 8, 2018
@TraGicCode @johlju
SqlWaitForAg: Updated unit tests to use latest unit test template (#1100
a1d3ea4 
)

- Changes to SqlWaitForAg
  -  Updated unit test template to version 1.2.1 (issue #1088)
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlWaitForAg: Updated unit tests to use latest unit test template
2 participants
@TraGicCode @johlju