Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlWaitForAg: Updated unit tests to use latest unit test template #1100

Merged
merged 3 commits into from
Apr 8, 2018
Merged

SqlWaitForAg: Updated unit tests to use latest unit test template #1100

merged 3 commits into from
Apr 8, 2018

Conversation

TraGicCode
Copy link
Contributor

@TraGicCode TraGicCode commented Apr 3, 2018

Pull Request (PR) description

Updated SqlWaitForAg unit tests to used latest unit test template.

This Pull Request (PR) fixes the following issues

Fixes #1088

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md? Entry
    should say what was changed, and how that affects users (if applicable).

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #1100 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1100   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        32      32           
  Lines      3930    3930           
====================================
  Hits       3844    3844           
  Misses       86      86

@johlju
Copy link
Member

johlju commented Apr 3, 2018

Just a small review comment. :)


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


CHANGELOG.md, line 32 at r1 (raw file):

    the following resources unit test template to version 1.2.1
    - SqlAlias ([issue #999](https://github.com/PowerShell/SqlServerDsc/issues/999)).
    - SqlWaitForAG ([issue #1088](https://github.com/PowerShell/SqlServerDsc/issues/1088)).

Since a new release was made, this is no longer under the Unreleased section. Could you move this new entry to the unreleased section? You can copy the 'Changes to Unit Tests' and 'Updated...' part as well. You can leave out your name for the time being and I will add that back in before next release. :)


Comments from Reviewable

@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Apr 3, 2018
@johlju
Copy link
Member

johlju commented Apr 3, 2018

@TraGicCode When you push the change we will see if the tests passes. The failed test has nothing to do with your change, it fails to download the media sometimes which makes the integration tests to fail. :/

I can close and directly reopen the PR to kick off the tests again, but will wait to see if it resolves with your next push.

@TraGicCode
Copy link
Contributor Author

CHANGELOG.md, line 32 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Since a new release was made, this is no longer under the Unreleased section. Could you move this new entry to the unreleased section? You can copy the 'Changes to Unit Tests' and 'Updated...' part as well. You can leave out your name for the time being and I will add that back in before next release. :)

Sorry that was me being in a hurry. Good catch. I completely missed the new release happening. Also Congrats 👯


Comments from Reviewable

@TraGicCode
Copy link
Contributor Author

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 32 at r1 (raw file):

Previously, TraGicCode (Michael Fyffe) wrote…

Sorry that was me being in a hurry. Good catch. I completely missed the new release happening. Also Congrats 👯

Done.


Comments from Reviewable

@TraGicCode
Copy link
Contributor Author

@johlju Rebuilding now!

@johlju johlju added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Apr 6, 2018
@johlju
Copy link
Member

johlju commented Apr 6, 2018

Just a tiny comment left 😄


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


CHANGELOG.md, line 4 at r2 (raw file):

## Unreleased
- Changes to Unit Tests

Should be a blank line before this one.

Tests are failing on lint error; https://ci.appveyor.com/project/PowerShell/sqlserverdsc/build/9.0.260.0?fullLog=true#L1592


Comments from Reviewable

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Apr 6, 2018
@TraGicCode
Copy link
Contributor Author

Done.


Comments from Reviewable

@TraGicCode
Copy link
Contributor Author

CHANGELOG.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should be a blank line before this one.

Tests are failing on lint error; https://ci.appveyor.com/project/PowerShell/sqlserverdsc/build/9.0.260.0?fullLog=true#L1592

Done.


Comments from Reviewable

@johlju
Copy link
Member

johlju commented Apr 8, 2018

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju changed the title Updated SqlWaitForAg unit tests to used latest unit test template. SqlWaitForAg: Updated unit tests to use latest unit test template Apr 8, 2018
@johlju johlju merged commit a1d3ea4 into dsccommunity:dev Apr 8, 2018
@vors vors removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Apr 8, 2018
@johlju
Copy link
Member

johlju commented Apr 8, 2018

@TraGicCode Thanks for that! One more down! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlWaitForAG: Update unit tests to use the same (newest) unit test template
4 participants