-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlWaitForAg: Updated unit tests to use latest unit test template #1100
SqlWaitForAg: Updated unit tests to use latest unit test template #1100
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1100 +/- ##
====================================
Coverage 97% 97%
====================================
Files 32 32
Lines 3930 3930
====================================
Hits 3844 3844
Misses 86 86 |
Just a small review comment. :) Reviewed 2 of 2 files at r1. CHANGELOG.md, line 32 at r1 (raw file):
Since a new release was made, this is no longer under the Unreleased section. Could you move this new entry to the unreleased section? You can copy the 'Changes to Unit Tests' and 'Updated...' part as well. You can leave out your name for the time being and I will add that back in before next release. :) Comments from Reviewable |
@TraGicCode When you push the change we will see if the tests passes. The failed test has nothing to do with your change, it fails to download the media sometimes which makes the integration tests to fail. :/ I can close and directly reopen the PR to kick off the tests again, but will wait to see if it resolves with your next push. |
CHANGELOG.md, line 32 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Sorry that was me being in a hurry. Good catch. I completely missed the new release happening. Also Congrats 👯 Comments from Reviewable |
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion. CHANGELOG.md, line 32 at r1 (raw file): Previously, TraGicCode (Michael Fyffe) wrote…
Done. Comments from Reviewable |
@johlju Rebuilding now! |
Just a tiny comment left 😄 Reviewed 1 of 1 files at r2. CHANGELOG.md, line 4 at r2 (raw file):
Should be a blank line before this one. Tests are failing on lint error; https://ci.appveyor.com/project/PowerShell/sqlserverdsc/build/9.0.260.0?fullLog=true#L1592 Comments from Reviewable |
Done. Comments from Reviewable |
CHANGELOG.md, line 4 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
@TraGicCode Thanks for that! One more down! 😄 |
Pull Request (PR) description
Updated SqlWaitForAg unit tests to used latest unit test template.
This Pull Request (PR) fixes the following issues
Fixes #1088
Task list
should say what was changed, and how that affects users (if applicable).
This change is